internal functions should not be documented with the eclass doc comments 
(_check_build_dir)

reusing a PM variable (ECONF_SOURCE) seems a little iffy

the library handling is incorrect.  i dont think you can pass around --enable-
shared all the time without having configure generate warnings about unknown 
options.  default to --disable-static when static-libs doesnt exist is wrong 
-- that's the opposite of what you should be doing.  ignoring the same issue 
as the share option i mentioned above.

pushd/popd should have stdout sent to /dev/null, not stderr too

the src_install func has the static-libs checks in the incorrect order

the src_test func looks like its copying & pasting stuff from the PM.  this 
really should be kept in the PM without duplicating it everywhere.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to