> # @CODE > # Michał Górny <[email protected]> > # @CODE
this is not what @code is designed for. punt it.
> : ${SCONS_MIN_VERSION}
useless statement. punt it.
> : ${EXTRA_ESCONS:=}
replace with @DEFAULT_UNSET
> scons ${MAKEOPTS} ${EXTRA_ESCONS} "$...@}"
this should be echoed just like emake and econf and other things do now.
set -- scons $(scons_makeopts) ${EXTRA_ESCONS} "$@"
echo "$@"
"$@"
> scons_clean_makeopts
better to do this on the fly and inline. otherwise you prevent the ebuild
from being used in conjunction with standard make builds.
i.e. have it parse ${MAKEOPTS} and echo the result, then change escons to call
it all by itself. this isnt something ebuild maintainers should be bothered
with. `escons` should be sufficient.
> scons_use()
keep the use_xxx style ... so rename it to "use_scons()"
> local varname=${2:-${flag}}
should be stripping possible leading ! so that people can do `use_scons !foo
moo` just like they can today with `use_with $foo moo`
-mike
signature.asc
Description: This is a digitally signed message part.
