On Mon, 29 Aug 2011 09:39:16 +0200 Tomáš Chvátal <[email protected]> wrote:
> >> # @ECLASS-VARIABLE: OOO_EXTENSIONS > >> # @REQUIRED > >> # @DEFAULT_UNSET > > > > I don't think you're supposed to mix these two. > Why? It make perfect sense, it is both required and empty by default. It is redundant. If a variable is required to be set, then its default value shouldn't even be set. Look at eclass-to-manpage.awk, @REQUIRED is perfectly enough. > >> die "Could not determine office implementation!" > > > > That sounds weird. > Why, it returns in the loop above that or thigger this code. > I consider it nicer than adding yet another useless condition. I mean the message text, 'office implementation' :D. KOffice may be an 'office implementation' as well. > > I think you should use local scope if you're intending to use > > 'insinto'. > > > What? I really don't get this :) Because caller can have his/her own 'insinto' and yours is going to override that. Look at do* in eutils.eclass. -- Best regards, Michał Górny
signature.asc
Description: PGP signature
