Re: [gentoo-dev] [RFC] office-ext.eclass

[Tomáš Chvátal]

Dne 30.8.2011 09:49, Michał Górny napsal(a):

On Tue, 30 Aug 2011 09:26:16 +0200
Tomáš Chvátal<scarab...@gentoo.org>  wrote:

# @FUNCTION: office-ext_remove_extension
[...]
        ${UNOPKG_BINARY} remove --shared "${ext}" \

Not sure what unopkg accepts, but I guess you want to pass several
arguments here. So ${ext} shouldn't be quoted.

And why is the intermediate variable ext needed here, in the first
place? You could use "$@" directly (this time, with the quotes).

Nah i want to give it just one argument, the name of the extension
and it can contain spaces ->  $@.

Then you are supposed to use "${1}", and caller is supposed to quote
that name.

Running things like 'foo bar baz' is a no go. If the file was named
'bar  baz' instead, it'd fail because of whitespace collapsing. So,
the only allowed solution is 'foo "bar baz"', and ${1}.

Good point, lets keep it $1 :)

For what is worth i prefer to use local variables just because it is
easier if I decide to change what i want to parse from $@ to
something else.

BTW You can go with exts=( "${@}" ) as well, to support multiple exts.

Nah too much arrays.

# Copyright 1999-2011 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $

# @ECLASS: office-ext.eclass
# @AUTHOR:
# Tomáš Chvátal <scarab...@gentoo.org>
# @MAINTAINER:
# The office team <openoff...@gentoo.org>
# @BLURB: Eclass for installing libreoffice/openoffice extensions
# @DESCRIPTION:
# Eclass for easing maitenance of libreoffice/openoffice extensions.

case "${EAPI:-0}" in
        4) OEXT_EXPORTED_FUNCTIONS="src_install pkg_postinst pkg_prerm" ;;
        *) die "EAPI=${EAPI} is not supported" ;;
esac

EXPORT_FUNCTIONS ${OEXT_EXPORTED_FUNCTIONS}
unset OEXT_EXPORTED_FUNCTIONS

inherit eutils multilib

UNOPKG_BINARY="${EPREFIX}/usr/bin/unopkg"

# @ECLASS-VARIABLE: OO_EXTENSIONS
# @REQUIRED
# @DESCRIPTION:
# Array containing list of extensions to install.
[[ -z ${OO_EXTENSIONS} ]] && die "OO_EXTENSIONS variable is unset."
if [[ "$(declare -p OO_EXTENSIONS 2>/dev/null 2>&1)" != "declare -a"* ]]; then
        die "OO_EXTENSIONS variable is not an array."
fi

DEPEND="virtual/ooo"
RDEPEND="virtual/ooo"

# @FUNCTION: office-ext_flush_unopkg_cache
# @DESCRIPTION:
# Flush the cache after removal of an extension.
office-ext_flush_unopkg_cache() {
        debug-print-function ${FUNCNAME} "$@"

        debug-print "${FUNCNAME}: ${UNOPKG_BINARY} list --shared > /dev/null"
        ${UNOPKG_BINARY} list --shared > /dev/null
}

# @FUNCTION: office-ext_get_implementation
# @DESCRIPTION:
# Determine the implementation we are building against.
office-ext_get_implementation() {
        debug-print-function ${FUNCNAME} "$@"
        local implementations=(
                "libreoffice"
                "openoffice"
        )
        local i

        for i in "${implementations[@]}"; do
                if [[ -d "${EPREFIX}/usr/$(get_libdir)/${i}" ]]; then
                        debug-print "${FUNCNAME}: Determined implementation is: 
\"${EPREFIX}/usr/$(get_libdir)/${i}\""
                        echo "${EPREFIX}/usr/$(get_libdir)/${i}"
                        return
                fi
        done

        die "Unable not determine libreoffice/openoffice implementation!"
}

# @FUNCTION: office-ext_add_extension
# @DESCRIPTION:
# Install the extension into the libreoffice/openoffice.
office-ext_add_extension() {
        debug-print-function ${FUNCNAME} "$@"
        local ext=$1
        local tmpdir=$(mktemp -d --tmpdir="${T}")

        debug-print "${FUNCNAME}: ${UNOPKG_BINARY} add --shared \"${ext}\""
        ebegin "Adding extension: \"${ext}\""
        ${UNOPKG_BINARY} add --shared "${ext}" \
                "-env:UserInstallation=file:///${tmpdir}" \
                "-env:JFW_PLUGIN_DO_NOT_CHECK_ACCESSIBILITY=1"
        eend $?
        rm -rf "${tmpdir}"
}

# @FUNCTION: office-ext_remove_extension
# @DESCRIPTION:
# Remove the extension from the libreoffice/openoffice.
office-ext_remove_extension() {
        debug-print-function ${FUNCNAME} "$@"
        local ext=$1
        local tmpdir=$(mktemp -d --tmpdir="${T}")

        debug-print "${FUNCNAME}: ${UNOPKG_BINARY} remove --shared \"${ext}\""
        ebegin "Removing extension: \"${ext}\""
        ${UNOPKG_BINARY} remove --shared "${ext}" \
                "-env:UserInstallation=file:///${tmpdir}" \
                "-env:JFW_PLUGIN_DO_NOT_CHECK_ACCESSIBILITY=1"
        eend $?
        flush_unopkg_cache
        rm -rf "${tmpdir}"
}

# @FUNCTION: office-ext_src_install
# @DESCRIPTION:
# Install the extension source to the proper location.
office-ext_src_install() {
        debug-print-function ${FUNCNAME} "$@"
        local i

        # subshell to not pollute rest of the env with the insinto redefinition
        (
                insinto 
$(openoffice-ext_get_implementation)/share/extension/install/
                for i in "${OO_EXTENSIONS[@]}"; do
                        doins "${i}"
                done
        )

        einfo "Remember that if you replace your office implementation,"
        einfo "you need to recompile all the extensions."
        einfo "Your current implementation location is: "
        einfo "    $(openoffice-ext_get_implementation)"
}

# @FUNCTION: office-ext_pkg_postinst
# @DESCRIPTION:
# Add the extensions to the libreoffice/openoffice.
office-ext_pkg_postinst() {
        debug-print-function ${FUNCNAME} "$@"
        local i

        for i in "${OO_EXTENSIONS[$@]}"; do
                openoffice-ext_add_extension "${i}"
        done

}

# @FUNCTION: office-ext_pkg_prerm
# @DESCRIPTION:
# Remove the extensions from the libreoffice/openoffice.
office-ext_pkg_prerm() {
        debug-print-function ${FUNCNAME} "$@"
        local i

        for i in "${OO_EXTENSIONS[@]}"; do
                openoffice-ext_remove_extension "${i}"
        done
}