>>>>> On Mon, 5 May 2014, Michał Górny wrote:

> Three quick patches for review:

> 1. adds multilib_get_enabled_abi_pairs() as a replacement for
> multilib_get_enabled_abis(). The latter returned just the value
> of ${ABI}, the new function returns ${use_flag}:${ABI} pairs.

> e.g.:

>   multilib_get_enabled_abis: x86 amd64
>   multilib_get_enabled_abi_pairs: abi_x86_32:x86 abi_x86_64:amd64

These will get included in the pathname of the build dir, right?

If yes, are you sure that all upstream build systems can cope with
the colon in path names? I'd rather suggest to stay within the POSIX
portable filename character set (i.e. [A-Za-z0-9._-]).

Ulrich

Attachment: pgpyxOts5zQqS.pgp
Description: PGP signature

Reply via email to