Dnia 2015-10-10, o godz. 18:50:51 "Brian Dolbec" <[email protected]> napisał(a):
> commit: 6d6b97e870f98e26a6e5de0712da048495057286 > Author: Brian Dolbec <dolsen <AT> gentoo <DOT> org> > AuthorDate: Sat Oct 10 17:47:28 2015 +0000 > Commit: Brian Dolbec <dolsen <AT> gentoo <DOT> org> > CommitDate: Sat Oct 10 18:49:55 2015 +0000 > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d6b97e8 (taking this as an example of common mistake, please don't take it personally) > sys-apps/portage: Add py3.5 compatibility to 2.2.23 and 9999. > > Clean out older versions. > Keep 2.2.8-r2 for python-2.6/3.2 upgrade compatibility. The commit message does not follow the standard guidelines for git commit messages. The summary line should describe the change shortly, and the body should expand on it. In your case, the summary line describes part of the change and the body part another change. As a result, a user looking at --oneline logs would see that you only added py3.5 compatibility while you also removed ebuilds. Furthermore, *please* don't mix old version removals with other changes. This makes it unnecessarily hard to revert breaking changes. Let's suppose you accidentally removed a version that had reverse dependencies. If you did it in a separate commit, we could quickly revert that commit and save users from seeing the breakage, and we could do the removal properly afterwards. When changes are mixed like this, you have to do partial reverts and partial re-commits, and things get unnecessarily hard. > Package-Manager: portage-2.2.23 > > sys-apps/portage/Manifest | 4 - > sys-apps/portage/portage-2.2.14.ebuild | 352 ------------------------------- > sys-apps/portage/portage-2.2.18.ebuild | 352 ------------------------------- > sys-apps/portage/portage-2.2.20.ebuild | 365 > --------------------------------- > sys-apps/portage/portage-2.2.22.ebuild | 363 -------------------------------- > sys-apps/portage/portage-2.2.23.ebuild | 2 +- > sys-apps/portage/portage-9999.ebuild | 2 +- > 7 files changed, 2 insertions(+), 1438 deletions(-) -- Best regards, Michał Górny <http://dev.gentoo.org/~mgorny/>
pgpujx6AAiIPl.pgp
Description: OpenPGP digital signature
