>>>>> On Mon, 30 Nov 2015, Davide Pesavento wrote: >> The patch below replaces them by case statements. (Unfortunately we >> cannot use fall-through (&;) because it is a bash 4 feature.)
> Sounds reasonable, although I'd find an 'if' clause slightly more
> readable, since there wouldn't be an 'else' branch in 2 out of 3
> cases.
It is slightly more complicated to match multiple patterns with [[ ]]
because it requires multiple conditions, regexps, or extglob. We could
of course use a bracket expression like [[ ${EAPI:-0} = [012345] ]]
but I find it ugly in this context (and it won't be able to check for
EAPI 10 ;) ).
Besides, case seems to be the command most used for EAPI checking in
eclasses.
Ulrich
pgpNz1_QauI1q.pgp
Description: PGP signature
