, Dnia 30 listopada 2015 07:52:59 CET, Ulrich Mueller <[email protected]> napisał(a): >>>>>> On Mon, 30 Nov 2015, Davide Pesavento wrote: > >>> The patch below replaces them by case statements. (Unfortunately we >>> cannot use fall-through (&;) because it is a bash 4 feature.) > >> Sounds reasonable, although I'd find an 'if' clause slightly more >> readable, since there wouldn't be an 'else' branch in 2 out of 3 >> cases. > >It is slightly more complicated to match multiple patterns with [[ ]] >because it requires multiple conditions, regexps, or extglob. We could >of course use a bracket expression like [[ ${EAPI:-0} = [012345] ]] >but I find it ugly in this context (and it won't be able to check for >EAPI 10 ;) ).
Do you expect those functions to be restored in the eclass in EAPI 10? As I see it, it's moot argument. > >Besides, case seems to be the command most used for EAPI checking in >eclasses. Because usually it has three branches, not one or two. > >Ulrich -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
