Peter Stuge <[email protected]> writes: >> + pushd "${EPREFIX}$(get_erl_libs)" >/dev/null >> + for p in ${pn} ${pn}-*; do >> + if [[ -d ${p} ]]; then >> + echo "${p#${pn}-}" >> + return 0 > > No popd on success?
Thanks for catching this up! Fixed.
>> + local tmpf="$(emktemp)"
>> +
>> + cat "${f}" >"${tmpf}" || return 1
>> + awk "$@" "${tmpf}" >"${f}"
>> +}
>
> Wouldn't it be nicer to cut cat, awk > $tmpf && mv $tmpf $f ?
No. Please see separate review of eawk where it is explained.
Thanks,
-- Amadeusz Żołnowski
signature.asc
Description: PGP signature
