Michał Górny <[email protected]> writes: >> >> + [[ -d include ]] && doins -r include >> >> + [[ -d bin ]] && for bin in bin/*; do dobin "$bin"; done >> > >> > Please don't do inlines like this. >> >> Is there a particular problem with this? > > Readability and maintainability. At some point someone may want to > extend this, and it will no longer work as one-liner.
That's rather subjective. Given the context I find concise. When uninlined it takes 4 lines more, gets out of context and looks more noisy to me. If someone would like to extend the inline version it could be uninlined at that point. -- Amadeusz Żołnowski
signature.asc
Description: PGP signature
