On 14-12-2017 13:39:18 +0100, Michał Górny wrote: > Dnia 14 grudnia 2017 13:21:47 CET, Fabian Groffen <grob...@gentoo.org> > napisał(a): > >Can we make it a policy to list /what/ QA issues are the justification > >for commits like these? A description in the commit message would be > >preferred, but a pointer to a location where said issues can be found > >would do too. > > Maintainer-needed is reason enough. If somebody couldn't be bothered to > maintain what he committed, why should we bother to list the issues? > > Using repoman and looking at CI mails is also a good idea.
Obviously for me to learn something, I won't/can't use repoman here. So a pointer to said CI mails from the message of the QA commit would be nice. Thanks, Fabian > > > >Thanks, > >Fabian > > > >On 14-12-2017 12:10:59 +0000, Andreas Hüttel wrote: > >> URL: > >https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34e2c43f > >> > >> Revert "dev-libs/libunibreak: initial import" > >> > >> Please write on the chalkboard 100 times: "I will not add ebuilds as > >maintainer-needed". > >> Also other QA issues. > >> This reverts commit 8b4ea0f6d2bed140116f69855d1d3100ea0cf020. > >> > >> dev-libs/libunibreak/Manifest | 1 - > >> dev-libs/libunibreak/libunibreak-4.0.ebuild | 39 > >----------------------------- > >> dev-libs/libunibreak/metadata.xml | 14 ----------- > >> 3 files changed, 54 deletions(-) > >> > >> diff --git a/dev-libs/libunibreak/Manifest > >b/dev-libs/libunibreak/Manifest > >> deleted file mode 100644 > >> index 487fd898f5d..00000000000 > >> --- a/dev-libs/libunibreak/Manifest > >> +++ /dev/null > >> @@ -1 +0,0 @@ > >> -DIST libunibreak-4.0.tar.gz 629403 SHA256 > >f7329bef1eb169d3363f040cefcc323cfd0a0bc53290a35a395e1d1adc849539 SHA512 > >43da73f66fabd8fdef444c5a06ad1800464a0aeab590938522d6c19973950a242f2ccc0575a93d10d87bdcf82610452117ac081ddb73f47271a8c2a65897e11c > >WHIRLPOOL > >ad71bc5910ca3dff994651022a5a6c6093cd4023852270fa243848f7576287b7cec4ad02a6b27686149491cb52824a93fdb6a6dac4c878d67db2f4041282d300 > >> > >> diff --git a/dev-libs/libunibreak/libunibreak-4.0.ebuild > >b/dev-libs/libunibreak/libunibreak-4.0.ebuild > >> deleted file mode 100644 > >> index f531bb66e38..00000000000 > >> --- a/dev-libs/libunibreak/libunibreak-4.0.ebuild > >> +++ /dev/null > >> @@ -1,39 +0,0 @@ > >> -# Copyright 1999-2017 Gentoo Foundation > >> -# Distributed under the terms of the GNU General Public License v2 > >> - > >> -EAPI=6 > >> -inherit versionator > >> - > >> -DESCRIPTION="Line and word breaking library" > >> -HOMEPAGE="http://vimgadgets.sourceforge.net/libunibreak/"; > >> > >-SRC_URI="https://github.com/adah1972/${PN}/releases/download/${PN}_$(replace_all_version_separators > >'_')/${P}.tar.gz" > >> - > >> -LICENSE="ZLIB" > >> -SLOT="0" > >> -KEYWORDS="~amd64 ~arm ~ppc ~x86" > >> -IUSE="doc +man static-libs" > >> - > >> -DEPEND="man? ( app-doc/doxygen )" > >> -RDEPEND="!dev-libs/liblinebreak" > >> - > >> -src_prepare() { > >> - use man && echo -e 'GENERATE_MAN=YES\nGENERATE_HTML=NO' >> Doxyfile > >> - default > >> -} > >> - > >> -src_configure() { > >> - econf \ > >> - $(use_enable static-libs static) > >> - use doc && export HTML_DOCS=( doc/html/. ) > >> -} > >> - > >> -src_compile() { > >> - default > >> - use man && doxygen || die > >> -} > >> - > >> -src_install() { > >> - default > >> - prune_libtool_files > >> - use man && find "${D}/usr/include" -type f -execdir doman > >"${S}/doc/man/man3/{}.3" \; > >> -} > >> > >> diff --git a/dev-libs/libunibreak/metadata.xml > >b/dev-libs/libunibreak/metadata.xml > >> deleted file mode 100644 > >> index a8bbb441f29..00000000000 > >> --- a/dev-libs/libunibreak/metadata.xml > >> +++ /dev/null > >> @@ -1,14 +0,0 @@ > >> -<?xml version="1.0" encoding="UTF-8"?> > >> -<!DOCTYPE pkgmetadata SYSTEM > >"http://www.gentoo.org/dtd/metadata.dtd";> > >> -<pkgmetadata> > >> - <!-- maintainer-needed --> > >> - <longdescription lang="en"> > >> - Libunibreak is an implementation of the line breaking and word > >breaking algorithms > >> - as described in Unicode Standard Annex 14 and Unicode Standard > >Annex 29. It is > >> - designed to be used in a generic text renderer. > >> - </longdescription> > >> - <use> > >> - <flag name="man">Generate man pages with doxygen.</flag> > >> - <flag name="doc">Install html API documentation.</flag> > >> - </use> > >> -</pkgmetadata> > >> > >> > > > -- > Best regards, > Michał Górny (by phone) > -- Fabian Groffen Gentoo on a different level
signature.asc
Description: Digital signature
