Ühel kenal päeval, E, 09.07.2018 kell 10:40, kirjutas Michał Górny: > Hi, > > We currently don't enforce any particular standard for e-mail > addresses > for developers committing to gentoo.git. FWICS, the majority of > developers is using their @gentoo.org e-mail addresses. However, a > few > developers are using some other addresses. > > Using [email protected] e-mail addresses generally causes problems > in accounting for commits. For example, our retirement scripts can't > detect commits made using non-Gentoo e-mail address. My dev-timeline > scripts [1] account for all emails in LDAP (which doesn't cover all > addresses developers use). FWIK gkeys accounts for all addresses > in the OpenPGP key UIDs. In my opinion, that's a lot of hoops to > jump > through to workaround bad practice. > > Therefore, I'd like to start enforcing (at the level of the hook > verifying signatures) that all commits made to gentoo.git (and other > repositories requiring dev signatures) are made using @gentoo.org e- > mail > address (for committer field). > > Is anyone opposed to that? Does anyone know of a valid reason to use > [email protected] address when committing?
As long as that doesn't imply authorship, which seems to be as planned (for committer field only, as you said). Hopefully it's easy for people to set it up so that it uses gentoo address for committer and something else for author, albeit I don't see any config for it, but should be able to at least go via a script that uses the appropriate env vars. That's then for work computers where the Gentoo developer is doing work necessary for his/her employer, on employers paid time. Appropriate then to have their work e-mail as author, especially if employer rightfully requests that to be used for authorship. But yeah, committer field should be fine, they can do author with one address, committer with Gentoo address. The only issue I see is that of slight complications on handling the different addresses for author and commit, that's all that comes to mind. Mart
signature.asc
Description: This is a digitally signed message part
