On Fri, 2021-08-13 at 12:31 +0200, Rolf Eike Beer wrote: > Am Freitag, 13. August 2021, 11:06:09 CEST schrieb Ulrich Mueller: > > > > > > > On Fri, 13 Aug 2021, Rolf Eike Beer wrote: > > > Am Donnerstag, 12. August 2021, 19:39:08 CEST schrieb Michael > > > Orlitzky: > > > > On Thu, 2021-08-12 at 17:22 +0200, Rolf Eike Beer wrote: > > > > > The default owner is root:root anyway. > > > > > > > > This is only true of you don't call insopts earlier with some > > > > other > > > > value. I see "insopts -o root -g qmail -m 700" in there so you > > > > might > > > > want to double check. > > > > > > Not my day. > > > > > > Ok, given that there are several places that change users and > > > groups > > > and the subfunctions are not always called it would be very few > > > places > > > where I can remove the root:root (about 3) and be sure that > > > everything > > > works. For that reason I would just keep them all and go back to > > > the > > > initial patch 2. > > > > I believe the method of choice would be to execute the offending > > insopts/doins pair in a subshell, i.e. put a ( ) pair around them. > > I will just do it the other way: explicitly reset it to defaults in > the 2 > functions that actually set something special.
Please us subshells instead, it makes local reasoning about the side- effects much easier.
