>>>>> On Sat, 14 Aug 2021, Rolf Eike Beer wrote:

> The default owner is root:root anyway, so just make sure other settings do not
> leak outside from the places where it is actually used. This also fixes
> qmail_supervise_install_one() when called from outside of qmail_src_install().

Looking at this patch again, I wonder about two points in general:

- diropts -m 0755 shouldn't be necessary. 0775 is dodir's default, and I
  don't see any diropts with another -m option in the eclass.

- insinto ...; insopts -m 0755; doins ... presumably indicates that the
  wrong tool is used, i.e. it should be exeinto ...; doexe ... instead.
  doexe already defaults to file mode 0755.

Ulrich

Attachment: signature.asc
Description: PGP signature

Reply via email to