On Wed, Nov 11, 2015 at 10:09:42PM -0800, Zac Medico wrote: > On 11/11/2015 02:30 PM, robb...@gentoo.org wrote: > > From: "Robin H. Johnson" <robb...@gentoo.org> > > > > If GIT_DIR is used, and .git is outside the root of the checkout, then > > --work-tree=... needs to be specified, otherwise any Git command that > > relies on relative directories to the root will be wrong. > > > > Signed-off-by: Robin H. Johnson <robb...@gentoo.org> > > --- > > bin/egencache | 31 +++++++++++++++++++++++-------- > > 1 file changed, 23 insertions(+), 8 deletions(-) > Looks good. Thanks, merged.
> > + '--relative=%s' % (cp, ), > This addition could be mentioned in the commit message. Added to the commit message. > > def run(self): > > - repo_path = self._portdb.porttrees[0] > > - os.chdir(repo_path) > > + os.chdir(self._repo_path) > The chdir calls make me nervous, since we should be careful to ensure > that they are timed correctly when we introduce parallelization. I'd > love to add a cwd argument for the grab method to pass into Popen, in > order to eliminate all of the chdir calls. Agreed; I like your later patch for it. -- Robin Hugh Johnson Gentoo Linux: Developer, Infrastructure Lead, Foundation Trustee E-Mail : robb...@gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
