On 02/05/2018 06:55 PM, R0b0t1 wrote:
> On Mon, Feb 5, 2018 at 8:33 PM, R0b0t1 <r03...@gmail.com> wrote:
>> On Sun, Feb 4, 2018 at 10:45 PM, Zac Medico <zmed...@gentoo.org> wrote:
>>> On 02/04/2018 07:22 PM, R0b0t1 wrote:
>>>> This is everything that shellcheck reported as an error. They are not
>>>> as serious as the globbing issue, but it would be a good idea to
>>>> change them. They are generally "type" issues (e.g. ">" instead of
>>>> "-gt").
>>>>
>>>> Some changes are shellcheck annotations. Very interesting was:
>>>>
>>>> eval "$x=(\"\${$x[@]}\" ${QA_PREBUILT//\*/.*})"
>>>>
>>>> Which looks like a bad array expansion ("$x[@]").
>>>
>>> I don't see a shellcheck error for that, using shellcheck-0.4.7. Maybe a
>>> false positive with an older version?
>>>
>>
>> 0.4.6, I will see if I can check.
>
> Still in 0.4.7.
Yeah, I just tried again and I'm seeing it now. I've found that adding
braces to ${x} suppresses it:
https://gitweb.gentoo.org/proj/portage.git/commit/?id=4a0a949d601969c672d9cf70ef8cf8682553f787
--
Thanks,
Zac
signature.asc
Description: OpenPGP digital signature
