On 10/27/19 10:40 AM, William Hubbs wrote: > Most upstreams and build systems do not make this distinction, so this > causes unnecessary hacks in ebuilds. > > Signed-off-by: William Hubbs <willi...@gentoo.org> > --- > bin/install-qa-check.d/80libraries | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/bin/install-qa-check.d/80libraries > b/bin/install-qa-check.d/80libraries > index d1d2c4fdd..e59369bf6 100644 > --- a/bin/install-qa-check.d/80libraries > +++ b/bin/install-qa-check.d/80libraries > @@ -152,16 +152,6 @@ lib_check() { > done > [[ ${abort} == "yes" ]] && die "add those ldscripts" > > - # Make sure people don't store libtool files or static libs in /lib > - f=$(ls "${ED%/}"/lib*/*.{a,la} 2>/dev/null) > - if [[ -n ${f} ]] ; then > - __vecho -ne '\n' > - eqawarn "QA Notice: Excessive files found in the / partition" > - eqawarn "${f}" > - __vecho -ne '\n' > - die "static archives (*.a) and libtool library files (*.la) > belong in /usr/lib*, not /lib*" > - fi > - > # Verify that the libtool files don't contain bogus $D entries. > local abort=no gentoo_bug=no always_overflow=no > for a in "${ED%/}"/usr/lib*/*.la ; do >
If we merge this patch then we need to make sure that we fix up the later code which currently assumes that *.{a,la} may only exist under /usr/lib* directories. -- Thanks, Zac
signature.asc
Description: OpenPGP digital signature