On Fri, 2019-12-13 at 23:49 +0100, Ulrich Mueller wrote: > > > > > > On Fri, 13 Dec 2019, Mike Gilbert wrote: > > > > It also triggers pointless bug reports. Please remove this. > > > > > > I don't like that eqawarn either (see above). > > > > > > OTOH, users shouldn't normally have "qa" in PORTAGE_ELOG_CLASSES, > > > so they won't see the warning? > > Here's a bug report filed by a user, which is what prompted me to > > reply on this thread in the first place. > > https://bugs.gentoo.org/702608 > > Well then, trivial patch included below. > > > From 81000b32d330a1cc41a4541f7e4264918eb7e6c5 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <u...@gentoo.org> > Date: Fri, 13 Dec 2019 23:41:23 +0100 > Subject: [PATCH] eapply: Drop QA warning for fuzz factor. > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > This didn't add any information beyond what is already present in the > output of patch. Developers will know how to interpret its output, and > users won't see the warning anyway with the standard configuration. > > Signed-off-by: Ulrich Müller <u...@gentoo.org> > --- > bin/phase-helpers.sh | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh > index b5691bd70..020862ba0 100644 > --- a/bin/phase-helpers.sh > +++ b/bin/phase-helpers.sh > @@ -1004,8 +1004,6 @@ if ___eapi_has_eapply; then > if ${patch_cmd} "${all_opts[@]}" --dry-run -s -F0 \ > < "${f}" &>/dev/null; then > all_opts+=( -s -F0 ) > - else > - eqawarn " ${f}: patch failed to apply > without a fuzz factor, please rebase" > fi > > ${patch_cmd} "${all_opts[@]}" < "${f}"
Actually, I added that because of your comment that people should be rebasing patches rather than removing context. -- Best regards, Michał Górny
signature.asc
Description: This is a digitally signed message part
