On 3/11/20 9:43 PM, Matt Turner wrote: > On Wed, Mar 11, 2020 at 9:36 PM Matt Turner <matts...@gentoo.org> wrote: >> >> On Wed, Mar 11, 2020 at 9:31 PM Zac Medico <zmed...@gentoo.org> wrote: >>> We can't can't continue above, since that will skip all of the filters >>> that occur later in the loop. So, we have to nest the below changed-deps >>> code under if options['changed-deps']: >> >> I'm happy to make that change, but I don't think it's necessary, >> strictly speaking, since this is inside an 'if not destructive' >> conditional and the only filter afterwards is 'if destructive'. > > Wait... the logic was if not destructive and > package-exists-in-porttree -> continue and do not add it to the dead > package list. > > I've just changed it so it does that if changed-deps is not set... so > keep the current behavior without --changed-deps. > > And if --changed-deps, check the porttree vs binpkg dependencies, and > if they still match, skip.
Yeah, you're right. > What is wrong with that logic? The coupling with --destructive logic complicates matters. It raises the question, why isn't --time-limit logic also coupled with --destructive logic? I think "in order to preserve the status quo" is a reasonable answer to this question. -- Thanks, Zac
signature.asc
Description: OpenPGP digital signature
