On 17 October 2011 09:15, Neil Bothwick <n...@digimed.co.uk> wrote:
> On Mon, 17 Oct 2011 00:35:35 +0200, Florian Philipp wrote:
>
>> preup() {
>>     if [ "$IFACE" = eth0 ]; then
>>         ebegin "Reloading broadcom and tg3 modules"
>>         modprobe -r foo bar &&
>>         modprobe broadcom &&
>>         modprobe tg3
>>         ewend $? "Failed to reload modules"
>>     fi
>>     return 0
>> }
>
> This seems more elegant than a separate init script, but do you want it
> to return 0 unconditionally? If the modules fail to load, surely you want
> the attempt to bring the interface up to abort?

In my head I find it less elegant to be honest.  Is it up to a network
configuration script to load the *kernel* module for the hardware?
-- 
Regards,
Mick

Reply via email to