That does seem to work, thanks.  So far the django 1.3 changes have only been

- changes to staticfiles in urls
- misc updates to some import calls to deprecated functions (generated
django warnings, not absolutely necessary until 1.5)
- adding csrf token to ajax calls
- update to requirements.txt to download 1.3

Not sure if there's anything else I'm missing, but it seems to be
working so far.



On Fri, Mar 23, 2012 at 12:31 PM, Jeffrey Johnson <[email protected]> wrote:
> Matt,
>
> I believe this snippet does the trick in
> src/GeoNodePy/geonode/templates/geonode/ext_header.html
>
> http://dpaste.de/IJreP/
>
> Let me know if that works for you. We should probably make a proper
> pull request for this if it does indeed do the trick.
>
> Jeff
>
> On Fri, Mar 23, 2012 at 9:24 AM, Matthew Hanson
> <[email protected]> wrote:
>> Well I'm using django 1.3 and things seemed to work ok, but when I
>> tried to change permissions I get a 403 error related to the ajax csrf
>> changes.   I took a look at Luke's django_1.3 branch but couldn't find
>> the commit where the csrf token was added to all ext ajax calls.   Can
>> anyone point me in the right direction to make this change?
>>
>> - matt
>>
>> On Wed, Mar 14, 2012 at 12:18 PM, Jeffrey Johnson <[email protected]> 
>> wrote:
>>> Im +1 on moving to 1.3 and even to 1.4 if its released soon. Luke if
>>> you can prepare a pull request for that, it would be stupendous.
>>>
>>> On Wed, Mar 14, 2012 at 1:56 AM, Luke Hatcher <[email protected]> wrote:
>>>> On Tuesday, March 13, 2012 at 12:15 PM, Matthew Hanson wrote:
>>>>
>>>> I recall some chatter last year about upgrading Django to 1.3 but it
>>>> wasn't done for the GeoNode 1.1 release. My experience with Django
>>>> is pretty much just 1.3, and specifically I was starting writing some
>>>> class-based views when I realized they aren't in django 1.2.
>>>>
>>>> If needed, the django-cbv package can be used to backport this feature to
>>>> Django 1.2 (http://pypi.python.org/pypi/django-cbv). I like to run the
>>>> latest versions of Django, but have used this to get around situations 
>>>> where
>>>> I have to use Django 1.2.x on projects.
>>>>
>>>> Anyone switch to 1.3, any tips or issues? It doesn't seem like it
>>>> should be all that difficult
>>>>
>>>> I think some GeoNode installs have upgraded already, and we did some 
>>>> testing
>>>> that in dicated things were working. With the upcoming Django 1.4 release
>>>> (likely one week from today unless any blockers come up), Django 1.2.x will
>>>> no longer be supported with security patches and moving to 1.3.x now is
>>>> probably a smart idea.
>>>>
>>>> Since the project is pinned to Django 1.2 at the moment, the upgrade path 
>>>> to
>>>> 1.3 might be a little rocky with the ajax csrf changes that came in with
>>>> 1.2.5. We've solved this in a few projects by including the csrf token in
>>>> any Ext ajax calls and it likely should be considered for core soon. Given
>>>> all of this (and if no one else has done it already), I might take a pass 
>>>> at
>>>> this and submit a pull request for others to review for upgrading to Django
>>>> 1.3.x in the next week.
>>>>
>>>> I changed shared/requirements.txt to use
>>>> django 1.3 but I'm having problems serving up static files, which I
>>>> know was changed 1.2->1.3.
>>>>
>>>> This is likely because of changes in staticfiles. In Django 1.3 staticfiles
>>>> is included in contrib and underwent a few changes. Without knowing your
>>>> specific settings, probably best to send you
>>>> to https://docs.djangoproject.com/en/dev/howto/static-files/#upgrading-from-django-staticfiles.
>>>>
>>>> Luke

Reply via email to