I’m fine with the behavior changing and agree it makes sense. Only issue is with it breaking someone’s existing good. Though I’d doubt if anyone would rely on that as an output, but you never know.
I think it’s still good to have a test for it in GEOS to catch these, so it can at least be noted in notes as a breaking change. I’ll take the test out of PostGIS if the behavior is kept in GEOS. Thanks, Regina From: geos-devel [mailto:geos-devel-boun...@lists.osgeo.org] On Behalf Of Martin Davis Sent: Friday, October 21, 2022 12:48 PM To: GEOS Development List <geos-devel@lists.osgeo.org> Subject: Re: [geos-devel] GEOS 3.12 regression failure in PostGIS Validity is only tested in the XY dimensions. So it's actually more appropriate that only the XY value is reported. On Fri, Oct 21, 2022 at 7:35 AM Regina Obe <l...@pcorp.us <mailto:l...@pcorp.us> > wrote: Hi all, PostGIS geos310 regression test, detailed here: https://trac.osgeo.org/postgis/ticket/5260 Started failing around October 18th. The test is this: SELECT '#168', ST_NPoints(g), ST_AsText(g), ST_isValidReason(g) FROM ( VALUES ('01060000C00100000001030000C00100000003000000E3D9107E234F5041A3DB66BC97A30F 4122ACEF440DAF9440FFFFFFFFFFFFEFFFE3D9107E234F5041A3DB66BC97A30F4122ACEF440D AF9440FFFFFFFFFFFFEFFFE3D9107E234F5041A3DB66BC97A30F4122ACEF440DAF9440FFFFFF FFFFFFEFFF'::geometry) ) AS v(g); I'm guessing might be caused by this commit - https://github.com/libgeos/geos/commit/32348a68c5212c89cfefab46891d2b3aada4a <https://github.com/libgeos/geos/commit/32348a68c5212c89cfefab46891d2b3aada4ab40> b40 which happened around the same time tests started failing. The difference from prior versions is that the 3.12 (main branch) now emits for isValidReason one less coordinate Too few points in geometry component[4275341.96977851 259186.966993061] Instead of: Too few points in geometry component[4275341.96977851 259186.966993061 1323.76295828331] Which to me makes sense if we are only considering 2 dimensions for validity. Before I change the test, I want to confirm that this is an intentional change. Thanks, Regina _______________________________________________ geos-devel mailing list geos-devel@lists.osgeo.org <mailto:geos-devel@lists.osgeo.org> https://lists.osgeo.org/mailman/listinfo/geos-devel
_______________________________________________ geos-devel mailing list geos-devel@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/geos-devel
