Hmmm... problematic definitely. It could be that the datastore disposal 
still has a few bugs in it. On 1.7.x that is now managed by the 
ResourcePool class.

I am not familiar with the connection pooling stuff that much. Should a 
connection pool be around for the life of the application and something 
independent of datastore disposal? If i remember properly the datastore 
factory creates a pool? SO i guess the answer is no.

I wonder if a datastore is being disposed but the application still has 
  reference to one...


Andrea Aime wrote:
> Hi,
> I have a user that sent me by private IM a stack trace
> that occurs only after he saves any modification to
> the GeoServer configuration, and disappears as soon
> as he restarts GeoServer:
> 
> ERROR [geotools.rendering] - Pool not open
> java.lang.IllegalStateException: Pool not open
>       at 
> org.apache.commons.pool.BaseObjectPool.assertOpen(BaseObjectPool.java:78)
>       at 
> org.apache.commons.pool.impl.GenericObjectPool.returnObject(GenericObjectPool.java:916)
>       at 
> org.apache.commons.dbcp.PoolableConnection.close(PoolableConnection.java:87)
>       at 
> org.apache.commons.dbcp.PoolingDataSource$PoolGuardConnectionWrapper.close(PoolingDataSource.java:181)
>       at org.geotools.data.jdbc.JDBCUtils.close(JDBCUtils.java:148)
>       at org.geotools.data.jdbc.QueryData.close(QueryData.java:200)
>       at 
> org.geotools.data.jdbc.JDBCFeatureReader.close(JDBCFeatureReader.java:66)
>       at 
> org.geotools.data.jdbc.JDBCFeatureReader.close(JDBCFeatureReader.java:62)
>       at 
> org.geotools.data.store.FeatureReaderIterator.close(FeatureReaderIterator.java:94)
>       at 
> org.geotools.data.store.FeatureReaderIterator.hasNext(FeatureReaderIterator.java:57)
>       at 
> org.geotools.renderer.lite.StreamingRenderer.processStylers(StreamingRenderer.java:1595)
>       at 
> org.geotools.renderer.lite.StreamingRenderer.paint(StreamingRenderer.java:642)
>       at 
> org.geotools.renderer.shape.ShapefileRenderer.renderWithStreamingRenderer(ShapefileRenderer.java:1472)
>       at 
> org.geotools.renderer.shape.ShapefileRenderer.paint(ShapefileRenderer.java:1341)
>       at 
> org.geotools.renderer.shape.ShapefileRenderer.paint(ShapefileRenderer.java:265)
> 
> By looking at the stack trace it seems the connection pool
> has been shut down, but the datastore has not been disposed of...
> which is something happening if you call dispose on the datastore,
> but not really let go of it.
> 
> Does it ring any bell? Seems a critical issue for anybody playing with
> databases
> Cheers
> Andrea


-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to