Jody Garnett wrote: > Justin Deoliveira wrote: >> Hi all, >> >> Running the wfs 1.1 cite tests popped out some issues with the bug fix >> for GEOS-2583, which outputs bounds for wfs 1.1 feature collections, >> and respects the service "featureBounding" configuration. >> >> The issues (of course) pops up in corner cases, such as encoding >> feature collections which have no geometric attributes, and empty >> feature collections. The first is a bug in the construction of simple >> feature types. Filed here: >> >> http://jira.codehaus.org/browse/GEOT-2373 >> >> The fix is more or less trivial, but to do it cleanly requires a >> change to a geoapi interface :( > It was not clear to me from this bug report what change to geoapi is > needed. The changes are pretty simple. Basically:
1) Change the javadoc of FeatureType a little bit, basically making the crs a first class property, and deriving it in cases where it is unset. 2) modify FeatureTypeFactory.createFeatureType() and createSimpleFeatureType() to take a CRS object. >> Which then requires us to do another geoapi milestone release, etc... >> I could hack around the problem and instantiate the >> SimpleFeatureTypeImpl directly... but I can see people having an issue >> with this, including myself. >> > Justin the timing is not bad on the geoapi side; I would like to make a > GeoAPI 2.2.0 anyways (so we can close off that branch with GeoTools > 2.5.x as its only user). I am doing a bunch of hacking this weekend with > Mark and would be willing to apply the patch and make a new GeoAPI > release for your Monday. I could go for this, but it involves getting people to agree that this is a worthy change. It sounds like we agree that it is. >> The issue of empty feature collection is an issue with one of the gml >> bindings, and is easily fixed. >> >> So options on how to proceed: >> 1) do the right thing, fix the bug in geotools, update geoapi and push >> back the release a few days >> > If this is an option; the timing for a geoapi release is good; I will > check on IRC if you are around to talk this over. I won't be around for most of today, and then I will be traveling over the weekend. I will give you my +1, but I would like to get approval from others like Andrea, Ben, Gabriel, etc... before proceeding. >> 2) roll back the fix for GEOS-2583, and live with the bug until the >> next release. >> 3) hack around the problem for now in geotools, and "promise" to fix >> it correctly for 1.7.4. >> >> Thoughts? I personally am ok with pushing back the release a few days >> to do the fix properly. Serves us right for trying to fix bugs at the >> last minute ;). >> > Jody > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
