Andrea Aime wrote: > Justin Deoliveira ha scritto: >> Hi all, >> >> Running the wfs 1.1 cite tests popped out some issues with the bug fix >> for GEOS-2583, which outputs bounds for wfs 1.1 feature collections, >> and respects the service "featureBounding" configuration. >> >> The issues (of course) pops up in corner cases, such as encoding >> feature collections which have no geometric attributes, and empty >> feature collections. The first is a bug in the construction of simple >> feature types. Filed here: >> >> http://jira.codehaus.org/browse/GEOT-2373 >> >> The fix is more or less trivial, but to do it cleanly requires a >> change to a geoapi interface :( Which then requires us to do another >> geoapi milestone release, etc... I could hack around the problem and >> instantiate the SimpleFeatureTypeImpl directly... but I can see people >> having an issue with this, including myself. >> >> The issue of empty feature collection is an issue with one of the gml >> bindings, and is easily fixed. >> >> So options on how to proceed: >> >> 1) do the right thing, fix the bug in geotools, update geoapi and push >> back the release a few days >> >> 2) roll back the fix for GEOS-2583, and live with the bug until the >> next release. >> >> 3) hack around the problem for now in geotools, and "promise" to fix >> it correctly for 1.7.4. >> >> Thoughts? I personally am ok with pushing back the release a few days >> to do the fix properly. Serves us right for trying to fix bugs at the >> last minute ;). >> > > This is my fault, and I'm totally ok to just revert the change that > triggered this issue (and I'm sorry for wasting your time on this) > (so I'd choose "pill" number 2). > > However, I'm a little confused by the whole issue. When no > geometric attributes are extracted and feature bounding > is requested nevertheless, GetFeature does two things: > * it puts the geometry attributes in the list of attributes > that have to be extracted anyways > * wraps the the returned feature collection with a > FeatureBoundsFeatureCollection that will return only > the requested attributes, but will leverage the raw > feature collection to compute the collection bounds and > the single feature bounds Not sure exactly, i would have to debug again to be sure what is happening. But at some point the CRS is lost. The envelope returned by FCFB.getBounds() has no CRS set on it. Perhaps this is the main issue and could be patched in FCFB directly. And asking the FCFB.getSchema() (which unless i am mistaken is the "view" of the actual type) for its CRS results in the issue I described above. > Soo... all of the above should not be happening? > What's going on? > > Cheers > Andrea >
-- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
