Good stuff David. I looked over the proposal quickly and did a quick code review and here is what i got:
* I wonder if the interface is better named MapDecoration, or MapOverlay? Decoration seems a bit too abstract * I notice the old package naming structure is being used in the community module * Decoration.findOptimalSize() requires javadocs. * This was brought up in IRC but I assume you are going to merge this into the core wms module? And I assume that the DecoratedRasterMapProducer class and the png-decorated output format will no longer be needed? * I notice when defining a decorator bean the example declares it as a non-singleton? Nothing in the interface to me would indicate that decorators would have to hold onto any state... so a singleton would be ok or is there some other reason? * Layouts are stored in the data directory? Are they stored under a "layouts" directory? The code indicates yes, just might want to mention it in the proposal. -Justin David Winslow wrote: > I have created a GSIP for this improvement. Open the feedback > floodgates! > > http://geoserver.org/display/GEOS/GSIP+35+-+WMS+Decorations > > -- > David Winslow > OpenGeo - http://opengeo.org/ > > On Mon, 2009-03-23 at 11:22 -0400, David Winslow wrote: >> Hi all, >> >> For a project I'm working on, I would like to be able to request a >> single PNG image from GeoServer that includes not only rendered map >> features, but also some overlays like a scale bar and a legend graphic. >> I have done some work on generalizing the already-present watermark >> code; in particular: >> * separating out the layout from the rendering logic (so now the >> watermark painter receives just a rectangle within the viewport and >> draws itself into that.) >> * adding a parameter to the paint method so that overlay providers can >> do context-sensitive things (like scale bars and geographically correct >> compasses) >> >> Additionally, I redid the layout code a bit to support offsets and >> multiple overlays in the same image request. (Attached is a demo image >> featuring everyone's favorite cactus monster [1]). >> >> The request is a standard WMS request specifying >> format=png-decorated&format_options=layout:mylayout where layout is a >> named configuration (currently the layout code doesn't actually read the >> configuration; it's just hard-coded for the demo above). I am currently >> thinking the configuration should have a 1:1 relationship with xml files >> in ${GEOSERVER_DATA_DIR}/layouts/; a sample configuration file in the >> format I am currently imagining is also attached. I'd be very >> interested in feedback on the configuration. >> >> So that's what I'm trying to accomplish. Ideally, I'd like to get this >> into the next release, but I don't think I will be able to deal with >> backward compatibility with the current watermark configuration, a >> stable configuration file, the user requirements for promotion, etc. in >> time. >> >> In the meantime, I have three questions: >> 1) May I commit this code as a community module? >> 2) Where on the wiki should this be documented while this feature is >> still under development? >> 3) What's wrong with the configuration file? >> >> -- >> David Winslow >> OpenGeo - http://opengeo.org/ >> >> [1] http://en.wikipedia.org/wiki/Monsters_of_Final_Fantasy#Cactuar >> ------------------------------------------------------------------------------ >> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are >> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and >> easily build your RIAs with Flex Builder, the Eclipse(TM)based development >> software that enables intelligent coding and step-through debugging. >> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com >> _______________________________________________ Geoserver-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel > > > ------------------------------------------------------------------------------ > _______________________________________________ > Geoserver-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
