All in all patch looks good David. And thanks for including test cases with it :).
One question I noted on the issue. Is ResourceInfo.getTitle() not suitable for the title? Or is it a different intention? Also, just a point of discussion (not a issue with the patch), I wonder if we should break out an actual class for this type of metadata? David Winslow wrote: > Hi all. I've done some work on adding support for the optional > Attribution field in the WMS capabilities document. I'd like a review > on the patch attached to http://jira.codehaus.org/browse/GEOS-3181 . > > The patch uses resource metadata to store title, link, and logo image > info for attribution on each layer, and provides a panel on the > Publishing tab for configuring them. If a layer has these properties, > then they are encoded during a capabilities request (since each field is > optional, my code will render a partial Attribution field if some of the > information is missing, eg, just a title and link if no logo is > provided.) > > Thanks. > > -- > David Winslow > OpenGeo - http://opengeo.org/ > > > ------------------------------------------------------------------------------ > Are you an open source citizen? Join us for the Open Source Bridge conference! > Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250. > Need another reason to go? 24-hour hacker lounge. Register today! > http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org > _______________________________________________ > Geoserver-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
