David Winslow wrote: > On Wed, 2009-06-24 at 10:03 +0800, Justin Deoliveira wrote: >> All in all patch looks good David. And thanks for including test cases >> with it :). >> >> One question I noted on the issue. Is ResourceInfo.getTitle() not >> suitable for the title? Or is it a different intention? > > The Attribution data describes the data provider, not the dataset > itself, so ResourceInfo.getTitle() is indeed different from the > Attribution Title. Fair enough. > >> Also, just a point of discussion (not a issue with the patch), I wonder >> if we should break out an actual class for this type of metadata? > > I would be +1 on this. I should note that when I tried to store an > AttributionInfo object in the metadata map, it was persisted using just > AttributionInfo.toString(). Is this the intended behavior? (and if so, > does this mean I need to implement a GeoTools Converter to store custom > objects in the metadata map? This page on the wiki says anything > Serializable is okay: > http://geoserver.org/display/GEOS/Adding+a+Configuration+Option-GS2 ) > Yeah... this is a issue. The metadata map says it can store anything serializable, but the xtream persister assumes it is just a string. To the persister should be patched. Do you want to open a seperate jira issue for this?
I would also be +1 for a AttributionInfo class, and adding LayerInfo.getAttribution(). What do others think? > -- > David Winslow > OpenGeo - http://opengeo.org/ > >> David Winslow wrote: >>> Hi all. I've done some work on adding support for the optional >>> Attribution field in the WMS capabilities document. I'd like a review >>> on the patch attached to http://jira.codehaus.org/browse/GEOS-3181 . >>> >>> The patch uses resource metadata to store title, link, and logo image >>> info for attribution on each layer, and provides a panel on the >>> Publishing tab for configuring them. If a layer has these properties, >>> then they are encoded during a capabilities request (since each field is >>> optional, my code will render a partial Attribution field if some of the >>> information is missing, eg, just a title and link if no logo is >>> provided.) >>> >>> Thanks. >>> >>> -- >>> David Winslow >>> OpenGeo - http://opengeo.org/ >>> >>> >>> ------------------------------------------------------------------------------ >>> Are you an open source citizen? Join us for the Open Source Bridge >>> conference! >>> Portland, OR, June 17-19. Two days of sessions, one day of unconference: >>> $250. >>> Need another reason to go? 24-hour hacker lounge. Register today! >>> http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org >>> _______________________________________________ >>> Geoserver-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
