Hi Ben,

Yeah... there does not seem to be a way to aggregate the results for all 
packages. The docs for the plug-in are not that great... perhaps there 
is something.

And yeah, cases such as implementing big apis is problematic. I guess 
you just have to take that into account when analyzing the results. The 
40% bar is a "soft one" imo that should take such things into account. 
For instance if a module fell at 39% and had a bunch of cases like this 
i would simply just "let it go", but yeah yeah, you have have to draw a 
line somewhere.

Maybe we need a better code coverage tool. We could try going back to 
clover... but it requires a special license, and maintainance of the 
license. The nice thing about cobertura is it works out of the box.

One thing I have been interested in looking at lately is sonar:

http://sonar.codehaus.org/

Which seems like a nice tool for doing this sort of stuff. No idea what 
the reports for code coverage look like or what engine it uses 
internally. Have you looked into it at all? Even looks like there is a 
hudson plugin available for it.

Ben Caradoc-Davies wrote:
> Justin,
> 
> the community module process requires an overall module unit test 
> coverage of 40% for promotion:
> http://docs.geoserver.org/1.7.x/developer/policies/community-modules.html
> 
> I can generate lovely and revealing reports with
> 
> mvn cobertura:clean cobertura:cobertura
> 
> but I do not see any overall module summary for either line or branch 
> coverage. How do you recommend assessing a module against the 40% 
> coverage requirement?
> 
> One weakness I notice in the coverage reports is that simple classes 
> that implement giant APIs (e.g. Collection, FeatureCollection) come off 
> poorly because they have many methods that consist entirely of "throw 
> new UnsupportedOperationException();". Is there any way to exclude these 
> from statistics, or are they there to remind us that giant APIs are a 
> code smell?
> 
> Kind regards,
> 


-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to