Gabriel Roldan wrote: > Justin Deoliveira wrote: >> I am actually sort of against mass formatting changes, as it usually >> ends up being more trouble than its worth. It also makes it really hard >> to apply patches among multiple branches. > concern shared. But for all means I mean it to try to keep it clean for > new classes and patches, etc. > As an example, the new UI is not affected by backwards patching > conflicts as it's a whole new thing, so that's perhaps _the_ one I would > like to mass format, and as said keep an eye on any new code. Hope that > makes more sense?
It does... but any mass format basically kills any ability to do svn blame. Which I think is pretty important. For instance when finding a line of code that has a problem it is nice to know if I was the one who wrote it originally, or it is someone else that i need to talk to about it. > >> That said, I don;t think that is what you are proposing. I would be a >> big +1 for enforcing more strictly code conventions via peer review. Or >> even if we could run a tool that would check for infractions. However >> that would probably require us to do a mass reformatting. >> >> 2c. >> >> Gabriel Roldan wrote: >>> Hi guys, >>> >>> It is a long time since I'm noticing an increasing loose of care on >>> applying the code formatting we're supposed to. Not to mention tabs >>> instead of spaces for indentation, lack of (c) headers, and even small >>> but bothering breaks of the code conventions, like lack of braces in >>> if statements. And also unused imports.. >>> >>> Question is, is this deliberate? I bet not and would like to encourage >>> all developers to systematically apply the formatting and follow >>> conventions as described in >>> <http://geoserver.org/display/GEOSDOC/1+Code+Conventions>. >>> >>> As we all use eclipse and the formatter is there please just try to >>> get used to press CTRL+ALT+F for formatting and CTRL+ALT+O for imports >>> clean up... please? >>> >>> Cheers, >>> >>> Gabriel >>> >>> ------------------------------------------------------------------------------ >>> >>> >>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 >>> 30-Day trial. Simplify your report design, integration and deployment >>> - and focus on what you do best, core application coding. Discover >>> what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july >>> _______________________________________________ >>> Geoserver-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Geoserver-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
