Andrea Aime wrote:
> Justin Deoliveira ha scritto:
>> Andrea Aime wrote:
>>> Gabriel Roldan ha scritto:
>>>> Hi guys,
>>>>
>>>> It is a long time since I'm noticing an increasing loose of care on
>>>> applying the code formatting we're supposed to. Not to mention tabs
>>>> instead of spaces for indentation, lack of (c) headers, and even
>>>> small but bothering breaks of the code conventions, like lack of
>>>> braces in if statements. And also unused imports..
>>> Agreed, that's annoying (quite a bit of the tabs are my fault, when
>>> I switched to Linux I forgot to setup again the GeoTools code
>>> convention).
>>>
>>> As for lack of braces, can you confirm that's part of the Sun Java
>>> coding convention? I really hate to add extra braces if not necessary,
>>> to me:
>>>
>>> if(xxx)
>>> // one liner
>>>
>>> reads much better than
>>>
>>> if(xxx) {
>>> // one liner
>>> }
>>
>> I have to disagree here. It is readable only when the whitespace is
>> formatted properly, and in many cases it is not. I prefer always to
>> use braces to be on the safe side, but that is just a personal
>> preference.
>
> I can go for that, but then let's make the Eclipse formatter enforce
> this.
>
> No comment on the function call spaces? Can we trade horses here? ;-)
> (nobody else actively committing with an opinion on this?)
Oops, sorry missed that in the email. Yes I know I do this and am
willing to give it up definitely, its just habit at this point. I need
to find a way to get my keyboard so zap me when i open a ( and follow it
with a space :)
But in the interest of code formatting I will make myself do this. But
please call me out when i forget.
>
> Cheers
> Andrea
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
