Justin Deoliveira ha scritto: > To chime in with my thoughts on this one: > > I like the idea a lot. How we handle proxying urls is something i have > never been that happy with. So if I understand correctly (and to sum up) > what this is entails is: > > 1) coming up with the "mangle" method, RequestUtils.buildURL() or > constructURL(). I actually prefer the name "postMangleURL()" as it seems > more descriptive to what is actually occurring. > > 2) Coming up with an extension point (URLConstructionCallback). Again > for naming purposes something like "URLMangler" seems more descriptive. > > 3) Every call to "proxifyBaseURL()" gets replaced with "buildURL()" (or > whatever it gets called).
Roger on the names > 4) The impl of "buildURL()" does a extension lookup and calls every url > callback, and also explicitly invokes the Proxifying url callback. I think the url proxification can be made as a plugin (just one that's always there, part of core) > As i understand it, this sounds good to me. > > Open question is does this require a GSIP? Good question. The change is not big, but affects every single module in the code base (~40 call points). So yeah, I'll write one. Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
