Hi Mathew,
I have updated the JIRA with some additional info. Thank you for adding this
new format to GeoTools.
In such a context, I have some brief notes and feedbacks on the patch you
provided:
- Please, never use a System.out.println in the code; use the logger instead
if you need to track something.
- When doing a "svn diff" or similar commands to create a patch, make sure
that experimental/debugging code lines doesn't go in the patch. (As an
instance, I have noticed that there are changes on
modules/library/sample-data/src/main/java/org/geotools/test/TestData.java
containing System.out.println calls.)
- Finally, instead of hardcoding the imageio-ext version within the
imageio-ext-gdal plugin module's pom, it is preferred to add a dependency
with only artifact-id and group-id; then, make sure to specify the version
in the main geotools pom, within the dependencyManagement section (note that
we specify that version by referring to an imageio.ext.version property to
avoid specifying in each tag the required version). By this way, when moving
to a new imageio-ext version, we only need to update the imageio.ext.version
property in the root's pom without touching any other poms/xml-tags .
I would like to point out that my feedbacks should be taken as constructive
instead of hostile criticism :)
I will update the geootols code with the new format, today.
Best Regards,
Daniele
On Wed, Mar 10, 2010 at 6:17 AM, <[email protected]> wrote:
> No worries Daniele, I have been pre-occupied with other things myself. I
> have put the patch into Jira - http://jira.codehaus.org/browse/GEOT-2971
>
> Thank you for the information on adding write functionality. I'm pleased to
> hear that it shouldn't be too much work.
>
> Mat
> ________________________________________
> From: [email protected] [[email protected]] On Behalf Of
> Daniele Romagnoli [[email protected]]
> Sent: Monday, 15 February 2010 10:10 PM
> To: Wyatt, Mathew (CESRE, Kensington)
> Cc: [email protected]
> Subject: Re: [Geoserver-devel] WCS output formats
>
> Hi again Mathew,
> sorry for the late reply.
> please, read below...
>
> On Sun, Feb 7, 2010 at 1:53 PM, <[email protected]> wrote:
> Hi Gabriel,
>
> I would like to contribute the code for my ENVIHdr plugin. How do I go
> about this?
>
> You can open a JIRA against the geotools imageio-ext-gdal module and attach
> the patch needed to add your code. I will take a look on it.
>
>
> Also, any guidelines/hint/instructions you can provide on how to write an
> ImageWriter plugin would be fantastic!
>
> In case you are talking about how to add writing capabilities to the
> ENVIHdr ImageIO-ext plugin, it is a very easy task, being the real writing
> code already contained in the gdalframework's base classes. The only things
> you need to do, is defining some format specific classes and do some tuning
> on them depending on the capabilities offered by the ENVIHdr driver. In
> order to do this, you can start by looking on the imageio-ext source code.
> To be more specific, you can refer to the gdalgeotiff or the gdalkakadujp2
> imageio-ext plugins since they also provide writing capabilities. Moreover,
> you can get some additional info, by taking a look on chapter 4 of the
> ImageI/O-Ext user guide [1].
>
> Hope this helps.
> Regards,
> Daniele
>
> [1]:
> https://imageio-ext.dev.java.net/files/documents/7505/124117/ImageioExt-UserGuide.pdf
>
>
> Cheers,
> Mat
> ________________________________________
> From: [email protected]<mailto:[email protected]> [
> [email protected]<mailto:[email protected]>] On Behalf Of
> Daniele Romagnoli [[email protected]<mailto:
> [email protected]>]
> Sent: Friday, 27 November 2009 7:55 PM
> To: Simone Giannecchini
> Cc: Wyatt, Mathew (E&M, Kensington); Geoserver-devel
> Subject: Re: [Geoserver-devel] WCS output formats
>
> Hi Mathew,
> great to see that you have added support for EnviHdr at geotools level.
> If you want to share with us your code we will take a look on it and we
> will include it in geotools.
> About the ENVIHdr ImageWriter plugin, adding it to the imageio-ext plugins
> should be a feasible task in a short amount of time. If you wish to do it by
> yourself, I can surely provide you some guidance lines.
>
> Let us know.
> Best Regards,
> Daniele
>
>
> On Thu, Nov 26, 2009 at 12:21 AM, Simone Giannecchini <
> [email protected]<mailto:
> [email protected]><mailto:
> [email protected]<mailto:
> [email protected]>>> wrote:
> Let's involve daniele who will be better than me in this discussion
> since he is the main responsible for the imageio-ext framework.
> Daniele, what is your feedback?
>
> Simone.
> -------------------------------------------------------
> Ing. Simone Giannecchini
> GeoSolutions S.A.S.
> Founder - Software Engineer
> Via Carignoni 51
> 55041 Camaiore (LU)
> Italy
>
> phone: +39 0584983027
> fax: +39 0584983027
> mob: +39 333 8128928
>
>
> http://www.geo-solutions.it
> http://geo-solutions.blogspot.com/
> http://simboss.blogspot.com/
> http://www.linkedin.com/in/simonegiannecchini
>
> -------------------------------------------------------
>
>
>
> On Wed, Nov 25, 2009 at 3:34 AM, Mathew Wyatt <[email protected]>
> wrote:
> > Hi Simone,
> >
> > I have a large amount of remote sensing data in ENVIHdr BSQ format,
> > that I would like to have delivered through a WCS. I have basically
> > just copied what you have done for the ESRIHdr files in geotools and
> > created an EnviHdrFormat etc. which utilizes the ENVIHdrImageReaderSpi
> > from imageio-ext. This appears to have made my data readable through
> > the WMS, WCS, as least from the small amount of testing I have done so
> > far. What I would like to do now is have the ENVIHdr files delivered
> > in their native format through the WCS.
> >
> > From what you have said, this means that write mode functionality
> > will have to be added to the imageio-ext libraries for ENVIHdr files
> > before a CoverageResponseDelegate can be written. How long would you
> > think it would take to add this sort of functionality to imageio-ext?
> >
> > Cheers,
> > Mat
> >
> > On 25/11/2009, at 8:10 AM, Simone Giannecchini wrote:
> >
> >> Ciao Matthew,
> >> EnviHDR is not supported in write mode, or at least no yet, it would
> >> be relatively easy to do that via imageio-ext.
> >> Just for the records, could please detail a bit more about what you
> >> have done geotools-wise to work with envi hdr?
> >>
> >> Simone.
> >> -------------------------------------------------------
> >> Ing. Simone Giannecchini
> >> GeoSolutions S.A.S.
> >> Founder - Software Engineer
> >> Via Carignoni 51
> >> 55041 Camaiore (LU)
> >> Italy
> >>
> >> phone: +39 0584983027
> >> fax: +39 0584983027
> >> mob: +39 333 8128928
> >>
> >>
> >> http://www.geo-solutions.it
> >> http://geo-solutions.blogspot.com/
> >> http://simboss.blogspot.com/
> >> http://www.linkedin.com/in/simonegiannecchini
> >>
> >> -------------------------------------------------------
> >>
> >>
> >>
> >> On Tue, Nov 24, 2009 at 4:03 AM, Mathew Wyatt
> >> <[email protected]> wrote:
> >>> Hi Andrea,
> >>>
> >>> Just for clarification. Is there any possibly way to have geoserver
> >>> wcs return the 'nativeFormat' of the data in question? I have made a
> >>> few attempts but had no success. Looking through the geoserver
> >>> codebase it appears I need to write a 'CoverageResponseDelegate' for
> >>> ENVIHdr files. Is this correct?
> >>>
> >>> Cheers,
> >>> Mat
> >>>
> >>> On 23/11/2009, at 4:39 PM, Andrea Aime wrote:
> >>>
> >>>> Mathew Wyatt ha scritto:
> >>>>> Hi,
> >>>>>
> >>>>> I have recently been adding functionality to geotools for it to
> >>>>> support ENVI Hdr data files.
> >>>>
> >>>> Nice! Do you plan to contribute that back to the GeoTools community?
> >>>> Getting a community module there is easy (and with some unit testing
> >>>> and commitment it can become an official module too).
> >>>>
> >>>>> I have managed to get the handler
> >>>>> working, and the files are viewable with the WMS, and accessible
> >>>>> through the WCS. Except:
> >>>>>
> >>>>> When I run the following WCS query, I am returned a .eml file,
> >>>>> instead
> >>>>> of a geotiff:
> >>>>>
> >>>>>
> http://localhost:8080/geoserver/wcs?service=WCS&request=GetCoverage&version=1.1.1&identifier=BlockAAlsmectiterelative&BoundingBox=235686.234,7880953.0,292701.234,7940609.5,urn:ogc:def:crs:EPSG::32754&format=image/geotiff
> >>>>>
> >>>>> Also, I would like geoserver to return me ENVI Hdr BSQ files -
> >>>>> possibly zipped. How would I go about adding functionality for a
> >>>>> custom output format to geoserver?
> >>>>
> >>>> That is not a problem with output formats, it's the WCS spec that
> >>>> _mandates_ one to return a mime/multipart response, the xml response
> >>>> describing the outputs is the main document and the geotiffs
> >>>> are attachments (sounds crazy, I know).
> >>>>
> >>>> If you don't like that you have to use WCS 1.0 or use store=true
> >>>> in WCS 1.1 and make two requests
> >>>>
> >>>> Cheers
> >>>> Andrea
> >>>>
> >>>> --
> >>>> Andrea Aime
> >>>> OpenGeo - http://opengeo.org
> >>>> Expert service straight from the developers.
> >>>
> >>> --
> >>> Mathew Wyatt
> >>> Software Engineer, CSIRO Exploration and Mining
> >>> AARC (Australian Resources Research Centre)
> >>> 26 Dick Perry Ave, Kensington WA 6151, Australia
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> Let Crystal Reports handle the reporting - Free Crystal Reports
> >>> 2008 30-Day
> >>> trial. Simplify your report design, integration and deployment -
> >>> and focus on
> >>> what you do best, core application coding. Discover what's new with
> >>> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> >>> _______________________________________________
> >>> Geoserver-devel mailing list
> >>> [email protected]<mailto:
> [email protected]><mailto:
> [email protected]<mailto:
> [email protected]>>
> >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
> >>>
> >
> > --
> > Mathew Wyatt
> > Software Engineer, CSIRO Exploration and Mining
> > AARC (Australian Resources Research Centre)
> > 26 Dick Perry Ave, Kensington WA 6151, Australia
> >
> >
> >
> ------------------------------------------------------------------------------
> > Let Crystal Reports handle the reporting - Free Crystal Reports 2008
> 30-Day
> > trial. Simplify your report design, integration and deployment - and
> focus on
> > what you do best, core application coding. Discover what's new with
> > Crystal Reports now. http://p.sf.net/sfu/bobj-july
> > _______________________________________________
> > Geoserver-devel mailing list
> > [email protected]<mailto:
> [email protected]><mailto:
> [email protected]<mailto:
> [email protected]>>
> > https://lists.sourceforge.net/lists/listinfo/geoserver-devel
> >
>
>
>
>
> --
> -------------------------------------------------------
> Eng. Daniele Romagnoli
> Software Engineer
>
> GeoSolutions S.A.S.
> Via Carignoni 51
> 55041 Camaiore (LU)
> Italy
>
> phone: +39 0584983027
> fax: +39 0584983027
> mob: +39 328 0559267
>
>
> http://www.geo-solutions.it
>
> -------------------------------------------------------
>
>
>
>
>
> --
> -------------------------------------------------------
> Eng. Daniele Romagnoli
> Software Engineer
>
> GeoSolutions S.A.S.
> Via Carignoni 51
> 55041 Camaiore (LU)
> Italy
>
> phone: +39 0584983027
> fax: +39 0584983027
> mob: +39 328 0559267
>
>
> http://www.geo-solutions.it
>
> -------------------------------------------------------
>
>
>
--
-------------------------------------------------------
Eng. Daniele Romagnoli
Software Engineer
GeoSolutions S.A.S.
Via Carignoni 51
55041 Camaiore (LU)
Italy
phone: +39 0584983027
fax: +39 0584983027
mob: +39 328 0559267
http://www.geo-solutions.it
-------------------------------------------------------
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
