On Thu, Nov 4, 2010 at 9:30 AM, <[email protected]> wrote: > I am currently working on replacing acegi security with spring security 2.0.6 > > Most of the time I have to replace the term "acegi" with a spring > security term. (import statements, class names,...). > > This requires modifying a lot of files resulting in a big patch. > > Additionally I have seen that geoserver code itself uses the term > "acegi". (package names, parameter names). > > The question is: > Should i also rename the geoserver "acegi" elements resulting in a > bigger patch to be consistent or or should I rename only the > necessary elements. ?
I would go for a full replacement, otherwise people reading the code won't understand where "acegi" comes from. Cheers Andrea ----------------------------------------------------- Ing. Andrea Aime Senior Software Engineer GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584962313 fax: +39 0584962313 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.linkedin.com/in/andreaaime http://twitter.com/geowolf ----------------------------------------------------- ------------------------------------------------------------------------------ The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now! http://p.sf.net/sfu/SAP-dev2dev _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
