On Fri, Aug 26, 2011 at 7:11 PM, Jody Garnett <[email protected]> wrote: > Questions: > Q1: If I shorten they "keys" how much client code am I going to break?
What keys? > Q2: Can I make the annotations consistent for @DescribeProcess > @DescribeParam @DescribeResult ? > I would like to go for: > - name (optional) name for the provided input, result or process if > provided. If not provided the name is taken from the java definition > - title - the display name or title used (optional) defaults to the > "name" > - description - description used in the capabilities or describe > process > Issues: > - @DescribeProcess title is not used; is this on purpose? Nope, it's a bug > - The @DescribeProcess and @DescribeParameter are inconsistent in hiding > java details or advertising them (where the java class name was used; in > this case the attribute name is not used) Can't make any sense of what you wrote here... the parameters name cannot be used because they don't last at runtime, the class name does. > - the name "name of the layer attribute containing the width of the buffer" > is a very long key Yeah, these processes are new-is and were not made by me... Go ahead and shorten the keys, they are indeed too long. That said, I imagine most people will just call the process using its java api: new BufferFeatureCollection().execute(fc, 15, "abc") Why complicate simple things? :) > - the "name of the layer attribute containing the width of the buffer" > cannot actually be used; it always fails with the indication that it *must* > have a value as minOccurs != 0; setting it to an empty string does not work > In short I am not finding "gs:BufferFeatureCollection" to be a good > replacement for the "gt:BufferedFeatureCollection" I just deleted. I have > been trying to update the geoserver tests one at a time; and given the issue > with "name of the layer attribute containing the width of the buffer" I am > not super confident that those code here has been used in the wild? These processes have been contributed by Synergis, not sure how they used them. Just quickly looked at them, they seemed to be working, so did the tests since they were in the build. I guess you changed something that broke the tests during the move? Cheers Andrea -- ------------------------------------------------------- Ing. Andrea Aime GeoSolutions S.A.S. Tech lead Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 962313 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.youtube.com/user/GeoSolutionsIT http://www.linkedin.com/in/andreaaime http://twitter.com/geowolf ------------------------------------------------------- ------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
