> > - The @DescribeProcess and @DescribeParameter are inconsistent in hiding
> > java details or advertising them (where the java class name was used; in
> > this case the attribute name is not used)
> Can't make any sense of what you wrote here... the parameters name cannot
> be used because they don't last at runtime, the class name does.
Cool; that explains that then. 
> > - the name "name of the layer attribute containing the width of the buffer"
> > is a very long key
> Yeah, these processes are new-is and were not made by me...
> Go ahead and shorten the keys, they are indeed too long.
> That said, I imagine most people will just call the process using its
> java api:
> 
> new BufferFeatureCollection().execute(fc, 15, "abc")
> 
> Why complicate simple things? :)
Because there is a swing ui to prompt the user for these things; so I expect 
the maps to run around and actually be used a bit. 
> > - the "name of the layer attribute containing the width of the buffer"
> > cannot actually be used; it always fails with the indication that it *must*
> > have a value as minOccurs != 0; setting it to an empty string does not work
> > In short I am not finding "gs:BufferFeatureCollection" to be a good
> > replacement for the "gt:BufferedFeatureCollection" I just deleted. I have
> > been trying to update the geoserver tests one at a time; and given the issue
> > with "name of the layer attribute containing the width of the buffer" I am
> > not super confident that those code here has been used in the wild?
> These processes have been contributed by Synergis, not sure how they used 
> them.
> Just quickly looked at them, they seemed to be working, so did the tests
> since they were in the build.
I fixed the tests; and added the min=0 (so that the one value could be null or 
empty string as per the java code checks.
> I guess you changed something that broke the tests during the move?
Not really it was just luck of the draw; I did update all the tests on the 
geoserver side but got my hudson builds out of order. 

Thanks for the feedback;
Jody
------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to