Hey Justin,
On Mon, Jul 9, 2012 at 10:44 PM, Justin Deoliveira <[email protected]>wrote:
> Hey Juan,
>
> All in all this proposal looks great. Nice work man.
>
Thanks a lot for taking a look at it
>
> One thing though is about the ServiceInfo object representations. I would
> expect them to match the representation stored on disk for the data
> directory. Its understandable why though don't through since there is a
> secondary interfaces / set of classes used for this loaded by extension
> point.
>
>
This makes sense, I guess I overlooked these and went straight to
ServiceInfo and didn't consider that there would be an extension point for
this. I agree, the xml should reflect what is on disk like we do with other
resources.
> The extension point is XStreamServiceLoader and you'll find subclasses for
> each of the ows services. I think we should use this for the xml and json
> representations of service objects. For an example of how to use the
> extension point see:
>
>
> https://github.com/geoserver/geoserver/blob/master/src/main/src/main/java/org/geoserver/config/GeoServerLoader.java#L621
>
I see how this class is loaded and have found the subclasses you mention
(WCSXStreamLoader, etc...) but I'm not sure which object you're referring
to when you say "we should return this for the xml and json representations
of service objects". Do you mean that I should use the load method to
return the specific ServiceInfo (i.e. WCSInfo) object that these subclasses
use? Something else? Sorry maybe I'm misunderstanding something obvious but
want to make sure.
>
> That is really the only thing i can find. The work is extremely complete
> with both tests and documentation. Nice work!
>
Thanks
> -Justin
>
> On Mon, Jul 9, 2012 at 12:01 PM, Juan Marín Otero <
> [email protected]> wrote:
>
>> All,
>>
>> With the migration to Git and creation of branch 2.2.x done, I'd like to
>> gather feedback on a proposed enhancement to the REST API that I worked on
>> a few weeks ago, which adds configuration options for global settings and
>> OWS services. I wrote a GSIP with the high level description of changes
>> introduced at the following URL:
>>
>>
>> http://geoserver.org/display/GEOS/GSIP+76+-+Extend+REST+API+to+configure+settings+and+OWS+services
>>
>> The associated patch with unit tests and documentation for these changes
>> is attached in the corresponding JIRA ticket at:
>>
>> https://jira.codehaus.org/browse/GEOS-5122
>>
>>
>> Thanks
>>
>> --
>> Juan Marín Otero
>> GIS Consultant
>>
>> -------Visita mi blog en---------------------
>> http://guachintoneando.blogspot.com
>> ---------------------------------------------------
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Geoserver-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>
>>
>
>
> --
> Justin Deoliveira
> OpenGeo - http://opengeo.org
> Enterprise support for open source geospatial.
>
>
--
Juan Marín Otero
GIS Consultant
-------Visita mi blog en---------------------
http://guachintoneando.blogspot.com
---------------------------------------------------
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
