Andrea, Justin
Thanks for the feedback on this, and sorry for getting back to you so late
but some things got in the way (including vacation). I've incorporated the
suggestions made by you, namely:
1. Change all endpoints to use PUT for both creation and update (no POST),
following the convention used by GeoServer's REST API described by Justin
2. Make sure the XML/JSON representation is the same one used when
serializing to disk, by using the XStreamServiceLoader extension point and
its corresponding subclasses to load and save the configuration for
ServiceInfo objects.
The patch has been updated (code, documentation and tests) in the
corresponding JIRA ticket:
https://jira.codehaus.org/browse/GEOS-5122
Thanks
On Wed, Jul 11, 2012 at 7:53 PM, Justin Deoliveira <[email protected]>wrote:
>
>
> On Wed, Jul 11, 2012 at 2:03 PM, Andrea Aime <[email protected]
> > wrote:
>
>> On Wed, Jul 11, 2012 at 8:37 PM, Juan Marín Otero <
>> [email protected]> wrote:
>>
>>> Andrea / Justin,
>>>
>>> Thanks for the feedback, I actually went back and forth with this a bit
>>> but ended up doing it the way the patch reflects and I don't even remember
>>> my reasoning but yours is sound, this should be an easy change. Am I
>>> reading correctly in that you consider that POST should not be used for any
>>> of these additional resources?
>>>
>>
>> Err.. I guess not. I mean, when a resource location is 100% predictable
>> and there is even a finite set of them,
>> POST seems overkill. Just my two cents, I'm not a REST guru
>>
>
> To reiterate my take I think post should be used when you have a
> homogeneous collection of items that has no fixed size. I don't think any
> of new endpoints meet this criteria.
>
>>
>> Cheers
>> Andrea
>>
>> --
>> Ing. Andrea Aime
>> GeoSolutions S.A.S.
>> Tech lead
>>
>> Via Poggio alle Viti 1187
>> 55054 Massarosa (LU)
>> Italy
>>
>> phone: +39 0584 962313
>> fax: +39 0584 962313
>> mob: +39 339 8844549
>>
>> http://www.geo-solutions.it
>> http://geo-solutions.blogspot.com/
>> http://www.youtube.com/user/GeoSolutionsIT
>> http://www.linkedin.com/in/andreaaime
>> http://twitter.com/geowolf
>>
>>
>
>
> --
> Justin Deoliveira
> OpenGeo - http://opengeo.org
> Enterprise support for open source geospatial.
>
>
--
Juan Marín Otero
GIS Consultant
-------Visita mi blog en---------------------
http://guachintoneando.blogspot.com
---------------------------------------------------
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
