Hi all,
I spent a few hours today reviewing the pending pull request from Niels
that adds support for iso application profile and a catalog store based
directly from the geoserver catalog to the existing csw community module.
https://github.com/geoserver/geoserver/pull/84/files
All in all it looks great. Big thanks to Niels and Andrea for all this
work. I did however run into a few hiccups when trying to build the modules
with tests.
1. UTF-8 vs ISO-8859-1 encoding issues
A few tests fail with error message complaining about invalid UTF-8 byte
sequences. Some of the test files contain some extended latin characters.
For instance:
https://github.com/geoserver/geoserver/blob/master/src/community/csw/csw-core/src/test/resources/org/geoserver/csw/records/Record_e9330592-0932-474b-be34-c3a3bb67c7db.xml
The error occurs when one of the tests tries to parse a
GetRecord response that contains the record. The resulting doc reports a
UTF-8 encoding and the getAsDOM method fails to parse it. Not sure the best
way to solve this one but i was able to fix the test with two approaches.
a. Change the record transformer to report a document encoding
of ISO-8859-1
b. Specify manually the ISO-8859-1 encoding when parsing the response,
essentially ovrerriding the UTF-8 encoding reported on the doc
This is an example of one of the tests that fail.
https://github.com/geoserver/geoserver/blob/master/src/community/csw/csw-core/src/test/java/org/geoserver/csw/GetRecordsTest.java#L243
2. Location of schema files
The pull request moves the csw schema files from the classpath root to a
package prefix of net/opengis so that AppSchemaResolver can find them. But
this then causes the classpath publisher to fail to find the and makes it
so that the schemas are no longer web accessible which causes a test to
fail.
An obvious solution would be to just copy the files back to the root,
keeping them in both places. But I wonder if AppSchemaResolver can be
configured to load them without the package prefix. Or we could potentially
modify ClasspathPublisher and add the ability to add a package prefix.
3. org.geoserver.csw.records.iso.GetRecordsTest failures
Some of the ISO GetRecords tests fail as they make assertions assuming that
the "cite:Forests" record will be in the first page of results. Easy fix
seemed to just increase the page size by using maxRecords to ensure all
results returned.
And that is it. Aside from those issues the modules build just fine. I have
pushed some changes up to my github that contain fixes for these issues:
https://github.com/jdeolive/geoserver/tree/csw
But i am not confident on the fixes for issues 1 and 2 above and would like
to hear from Andrea and Niels.
I also took the liberty of fixing some minor issues as well including:
* cleaned up formatting issues with changes to main module catalog classes
(tabs vs spaces)
* removed csw- prefix from csw modules, as per convention with other multi
module roots like web, etc... the directory tree now looks like:
csw/
api/
core/
simple-store/
The artifact ids retain the csw prefix though.
-Justin
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
