On Thu, Jan 24, 2013 at 6:56 AM, Niels Charlier <ni...@scitus.be> wrote:
>
>
>> So if I understand this correctly this means two additional changes.
>>
>> 1. Remove the ElementSet argument from CatalogStore.getRecords() method.
>> 2. Remove CatalogStore.**translateProperty()
>>
>> (1) is trivial, more or less all calls to it passed in null. Made that
>> change and tests are happy.
>>
>> (2) is not so clear to me. At the moment there is code calling this
>> method, and multiple implementations of of it, one from
>> AbstractCatalogStore and one from InternalCatalogStore which appear to be
>> doing different things. So it's not quite obvious to me what should be done
>> here.
>>
>
> Oh no, only 1 needs to be changed, the second is indeed necessary as I
> explained further in the email. I was just apologising for the missing
> javadoc for the method, making it harder to understand.
>
> Ok cool. Thanks Niels. So (1) is indeed trivial, made that change.
For (2) all we need is a javadoc. I am still having a bit of trouble
understanding, mostly due to my inexperience with catalog. But it sounds
something like this:
/**
* Maps a qualified name to it's equivalent property name used to query
the backend store.
*/
A couple of additional questions though.
1. This method wold never be called by "client" code, it is more an
internal method used to the mapping?
2. How does this method relate to RecordDescriptor.translateProperty() ?
Don't worry - the changes are in fact trivial.
>
> Kind Regards
> Niels
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
