On 02/07/2013 02:02 PM, Andrea Aime wrote:
On Thu, Feb 7, 2013 at 1:57 PM, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote:Rather than being needlessly complicated I believe I have caused confusion by giving these two methods the same name - I should not have done that. What they have in common is that they both convert from Name to PropertyName, other than that they serve a completely different purpose.On 02/06/2013 06:22 PM, Andrea Aime wrote: The idea that there are two separate ways to translate between the internal data model and the exposed data model bugs me, seems redundant and needlessly complicated. How do you mean there are two separate ways to translate between internal and exposed data model? I don't believe there is, I'm a bit puzzled here by what you mean exactly.The record descriptor provides one, and then you added another to the store
It is the method in the record descriptor that translates between the internal and exposed data model.
The method in the store is merely there to tell what sort of conversion we need for a particular purpose; this is different in both stores for very good reasons, which I could elaborate. By creating the method it is possible to keep a bunch of other code the same for both stores. It's all been a part of the process of making code more generic and prevent copy-pasting, and simplifying - not complicating things. I should be more careful with name choosing to avoid confusion though.
Of course I'd be happy with any ideas or suggestions to improve the code. Niels
------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
