On 17 April 2014 11:11, Andrea Aime <andrea.a...@geo-solutions.it> wrote
>
>
> I see. There is no toFilter method in your proposal, you mean
> getSecurityFilter yes?
> toFilter would imply some sort of conversion, getSecurityFilter (or
> getCatalogFilter if you like) seem more appropriate.
>
Sorry, toFilter is what I had first thought of, and I renamed it to
getSecurityFilter when writing the proposal. I must have switched back
without thinking about it.
>
> I would avoid polluting the interface with a reference to catalog, we live
> in a spring world, implementation can either have it injected (better), or
> call GeoServerExtensions.bean("catalog")
> (uglier, still working) to grab a reference if they need to
>
> Ugh, those static calls to GeoServerExtensions.bean can be such a pain
when it comes to testing. I take your point about going for a Springy
solution though and leave the function signatures as is.
--
Kevin Smith
Junior Software Engineer | Boundless
ksm...@boundlessgeo.com
+1-778-785-7459
@boundlessgeo <https://twitter.com/boundlessgeo>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
