I note the tension between a minimal API for development and opening the
door for ease of testing.
Here is what I am testing now:
* renamed the methods as init( name, bean ) and init( applicationContext ).
* added a check to init(name,bean) to detect any conflict with
applicationContext
* changed the flag to isSpringContext, and the javadocs to describe
additional consistency checks
Let me know if that is sufficient.
Jody Garnett
On Tue, Apr 22, 2014 at 5:53 PM, Andrea Aime
<[email protected]>wrote:
> On Tue, Apr 22, 2014 at 9:45 AM, Jody Garnett <[email protected]>wrote:
>
>> I have added two static methods on pull request 568:
>>>>
>>>> GeoServerExtensions.mock( context );
>>>> GeoServerExtensions.mock("resourceLoader", resourceLoader);
>>>>
>>>
>>> I'm against having testing code creep into the normal API so explicitly.
>>>
>>
>> I can change the method to be a bit less obvious, but we are kind of
>> stuck since GeoServerExtensions is acting a singleton (much like
>> GeoserverDataDirectory before it).
>>
>
> Methods that can be of general use are ok, just not stuff that is clearly
> geared towards testing, that has no place in normal API.
>
> Cheers
> Andrea
>
> --
> ==
> Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
> for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
