On Tue, Apr 22, 2014 at 7:59 AM, Jody Garnett <[email protected]>wrote:
> I have already looked - as part of trying to address Kevin's feedback, I
> am trying to do this quickly to move on to my next pull request.
>
> GeoServerMockTestSupport happens a little late for factories that use
> GeoServerExtensions during
> We previously had some code using the GeoserverDataDirectory singleton to
> access a GeoServerResourceLoader. I have tried to move this to
> GeoSeverExtensions.
>
> Still if you like I can make a GeoServerExtensionsUtil in the same package
> and use package visibility to get access to GeoServerExtensions internals
> (to edit the singleton cache).
>
You're not being clear about the motivation here, or at least i can't infer
it from this conversation. Can you just point me at a specific test case
that Kevin has written.
--
> Jody Garnett
>
>
> On Tue, Apr 22, 2014 at 11:42 PM, Justin Deoliveira <
> [email protected]> wrote:
>
>>
>>
>>
>> On Tue, Apr 22, 2014 at 7:23 AM, Jody Garnett <[email protected]>wrote:
>>
>>> You are correct that that is a workaround if you have an application
>>> context.
>>>
>>> The key motivation is Kevin asking for for a way to quickly set
>>> GeoServerResourceLoader for test cases that want to look it up using
>>> GeoServerExtensions.bean(GeoServerResourceLoader.class).
>>>
>>> I added GeoServerExtensions.init( name, bean ) to make writing these
>>> test cases easier.
>>>
>>> Well my preference would be to not change the main api, and add a test
>> utility class that makes this easy. Also note that during the big test
>> change over last year we added some test utility classes to main to make
>> mocking up a GeoServer (and I am speaking true mocks here) easier. Look at
>> GeoServerMockTestSupport in org.geoserver.data.test. Perhaps you could put
>> what you need there.
>>
>>
>>> Jody Garnett
>>>
>>>
>>> On Tue, Apr 22, 2014 at 11:16 PM, Justin Deoliveira <
>>> [email protected]> wrote:
>>>
>>>> Sorry, I am having trouble figuring out the issue here, is there a pull
>>>> request or patch to provide some context?
>>>>
>>>> Is the problem that you don't like doing this?
>>>>
>>>> new GeoServerExtensions().setApplicationContext( context );
>>>>
>>>> Why not just throw it in a test utility method and call it a day? Why
>>>> do you have to modify GeoServerExtensions directly?
>>>>
>>>>
>>>>
>>>>
>>>> On Tue, Apr 22, 2014 at 2:33 AM, Jody Garnett
>>>> <[email protected]>wrote:
>>>>
>>>>> Yep, I will finish testing and hold off hitting merge until we hear
>>>>> from Justin.
>>>>> I doubt there is much good to be done here, GeoServerExtensions is
>>>>> still an improvement on what was before.
>>>>>
>>>>> Jody Garnett
>>>>>
>>>>>
>>>>> On Tue, Apr 22, 2014 at 6:28 PM, Andrea Aime <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> On Tue, Apr 22, 2014 at 10:24 AM, Jody Garnett <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> I note the tension between a minimal API for development and opening
>>>>>>> the door for ease of testing.
>>>>>>>
>>>>>>> Here is what I am testing now:
>>>>>>> * renamed the methods as init( name, bean ) and init(
>>>>>>> applicationContext ).
>>>>>>> * added a check to init(name,bean) to detect any conflict with
>>>>>>> applicationContext
>>>>>>> * changed the flag to isSpringContext, and the javadocs to describe
>>>>>>> additional consistency checks
>>>>>>>
>>>>>>> Let me know if that is sufficient.
>>>>>>>
>>>>>>
>>>>>> Looks better to me. It would be nice if Justin could have a look as
>>>>>> well
>>>>>>
>>>>>> Cheers
>>>>>> Andrea
>>>>>>
>>>>>> --
>>>>>> ==
>>>>>> Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
>>>>>> for more information.
>>>>>> ==
>>>>>>
>>>>>> Ing. Andrea Aime
>>>>>> @geowolf
>>>>>> Technical Lead
>>>>>>
>>>>>> GeoSolutions S.A.S.
>>>>>> Via Poggio alle Viti 1187
>>>>>> 55054 Massarosa (LU)
>>>>>> Italy
>>>>>> phone: +39 0584 962313
>>>>>> fax: +39 0584 1660272
>>>>>> mob: +39 339 8844549
>>>>>>
>>>>>> http://www.geo-solutions.it
>>>>>> http://twitter.com/geosolutions_it
>>>>>>
>>>>>> -------------------------------------------------------
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Start Your Social Network Today - Download eXo Platform
>>>>> Build your Enterprise Intranet with eXo Platform Software
>>>>> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
>>>>> Get Started Now And Turn Your Intranet Into A Collaboration Platform
>>>>> http://p.sf.net/sfu/ExoPlatform
>>>>> _______________________________________________
>>>>> Geoserver-devel mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> *Justin Deoliveira*
>>>> Vice President, Engineering | Boundless
>>>> [email protected]
>>>> @j_deolive <https://twitter.com/j_deolive>
>>>>
>>>
>>>
>>
>>
>> --
>> *Justin Deoliveira*
>> Vice President, Engineering | Boundless
>> [email protected]
>> @j_deolive <https://twitter.com/j_deolive>
>>
>
>
--
*Justin Deoliveira*
Vice President, Engineering | Boundless
[email protected]
@j_deolive <https://twitter.com/j_deolive>
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
