On Sun, Apr 20, 2014 at 7:04 PM, Justin Deoliveira <
[email protected]> wrote:
> +1 on the idea. Personally I am fine without a proposal for this one, I do
> have a couple of questions though.
>
> Where will the extension point be invoked from? XStreamPersister itself,
> or from XStreamPersisterFactory? I would vote for the latter as I think it
> would be nice to keep that outside of the persister itself.
>
> Should the interface take an instance of the persister rather than the
> underlying xstream? Rationale is that since we expose some other methods on
> XStreamPersister that configure how things are encoded I wonder if we may
> want to make those (along with future methods) available to the plugins as
> well?
>
Sounds good to me, in this case the interface becomes:
XStreamPersisterInitializer {
/**
* Allows XStream customizations. Plugins can use this to add aliases and
* custom converters for their own configuration objects
*/
void init(XStreamPersister persister);
}
and it will be called in both methods of XStreamPersisterFactory before
returning a XStreamPersister
to the caller.
I've created a pull request with the above and a test, and discovered it's
actually better than was I proposed for my own
needs, as I also needed to register the bean with the brief map handling to
make things work:
https://github.com/geoserver/geoserver/pull/571
Cheers
Andrea
--
==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
