Hi,
This looks pretty straightforward. To implement this, I guess I would have
to do the following
1. Create an extension module under geoserver for wfs-ng (there's no such
extensionsion yet)
2. Have that extension depend on gt-wfs-ng
3. Include code in the extension which registers the XStreamPersisters
required
The code in 3. would serialize & deserialize the configuration objects.
This glue would need to live in the geoserver extension as XStreamPersister
is part of gs, not gt. The actual configuration objects would be part of
gs-wfs-ng.
Is configuring the XStreamPersisterInitializer impl as a spring bean enough
to get the initializer registered?
What about name collision? This mechanism seems to register all
XStreamPersisterInitializers for all XStream persisters. Isn't there a
danger that an extension might register a name already in use for another
extension?
S.
On Tue, Apr 22, 2014 at 2:46 PM, Andrea Aime
<[email protected]>wrote:
> On Sun, Apr 20, 2014 at 7:04 PM, Justin Deoliveira <
> [email protected]> wrote:
>
>> +1 on the idea. Personally I am fine without a proposal for this one, I
>> do have a couple of questions though.
>>
>> Where will the extension point be invoked from? XStreamPersister itself,
>> or from XStreamPersisterFactory? I would vote for the latter as I think it
>> would be nice to keep that outside of the persister itself.
>>
>> Should the interface take an instance of the persister rather than the
>> underlying xstream? Rationale is that since we expose some other methods on
>> XStreamPersister that configure how things are encoded I wonder if we may
>> want to make those (along with future methods) available to the plugins as
>> well?
>>
>
> Sounds good to me, in this case the interface becomes:
>
> XStreamPersisterInitializer {
>
> /**
> * Allows XStream customizations. Plugins can use this to add aliases and
> * custom converters for their own configuration objects
> */
> void init(XStreamPersister persister);
>
> }
>
> and it will be called in both methods of XStreamPersisterFactory before
> returning a XStreamPersister
> to the caller.
>
> I've created a pull request with the above and a test, and discovered
> it's actually better than was I proposed for my own
> needs, as I also needed to register the bean with the brief map handling
> to make things work:
> https://github.com/geoserver/geoserver/pull/571
>
> Cheers
> Andrea
>
> --
> ==
> Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
> for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
--
Sampo Savolainen
R&D Director, Spatineo Oy
[email protected]
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc
This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
