On Fri, Jan 29, 2016 at 1:57 PM, Niels Charlier <[email protected]> wrote:
> Andrea, have I addressed your questions well enough with my changes?
>
Yes and no. I can now see the representation, and confirm the answer to
"are they properly interlinked via atom links?" has a negative answer.
The ResourceMetadata xml representation should be follow the same resource
interlinking
approach as our main REST API, for example:
<ResourceMetaData>
<name> nameOfFile </name>
<parent>
<path>path/to/parent</path>
<atom:link xmlns:atom="http://www.w3.org/2005/Atom";
rel="alternate" href="
http://localhost:8080/geoserver/rest/resource/path/to/parent.xml";
type="application/xml"/>
<parent>
<lastModified> date </lastModified>
<type> UNDEFINED | RESOURCE | DIRECTORY </type>
</ResourceMetaData>
and the same should be valid for the json representation.
Same goes for the directory representation.
>
> Do we agree on removing POST altogether (have not yet changed this in
> the proposal yet)?
>
I'd remove POST, two ways to do exactly the same things seem redundant to
me,
not sure what other think... maybe the API is easier to use if one does not
have to remember whether to use PUT or POST? :-)
There are questions that still do not get an answer in the proposal, see as
follows:
> * Determine what happens if format is used against a file resource
> > (that I assume we cannot transcode to another format), and what mime
> > type will be returned for them (e.g., property files)
> Format is only used for metadata and directories. Otherwise, you get the
> actual file in its own format.
>
Yes, but what mime type do we get? You have to return one right?
I understand it's hard to guess the mime type of a random file, so one
could say
that it's going to be "application/octet-stream", which is the most generic.
Or maybe you want to apply some special treatment to well known extensions,
like .properties and .xml or .sld.
I see that Java 7 has this useful API, maybe it can be used for a guess?
http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#probeContentType%28java.nio.file.Path%29
In any case, the proposal should state something in this respect.
Writing the above I actually raised one more question: what happens if
someone
goes and chances configuration files using the resource REST api?
It's ok to say "it's store implementation dependent", but at least we
should make
a statement on that (otherwise people will start assuming that the behavior
of one store is actually valid for all stores).
Oh, and one final question, I see it's a proposal, I'm assuming this means
these
new endpoints will be folded in the main rest API, instead of being a
community
module, right?
So is it going to be implemented using the same library as the main REST
api?
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
