I see what you mean. Sorry, I was mixing up CatalogImpl and CatalogFacade in my head there (I was thinking you meant to remove the current workaround from the facade).
Yes, that change does make sense. Torben On Tue, Nov 15, 2016 at 10:23 AM, Andrea Aime <[email protected]> wrote: > On Tue, Nov 15, 2016 at 4:41 PM, Torben Barsballe < > [email protected]> wrote: > >> I agree that would be a good idea, although that would technically be a >> reduction in functionality... perhaps some sort of warning in the logs for >> 1 version, then removal later? >> > > I lost you, why would it be a regression? Being able to set a workspace > that is not even in the catalog > as the default seems to be a bug... but wait... I see this in CatalogImpl: > > public void setDefaultWorkspace(WorkspaceInfo workspace) { > if (workspace != null && > facade.getWorkspaceByName(workspace.getName()) > == null) { > facade.add(workspace); > } > facade.setDefaultWorkspace(workspace); > } > > > So what about changing it roughly this way: > > public void setDefaultWorkspace(WorkspaceInfo workspace) { > if (workspace == null) { > facade.setDefaultWorkspace(workspace); > } > WorkspaceInfo ws = facade.getWorkspaceByName(workspace.getName()); > if(ws == null) { > facade.add(ws); > } > facade.setDefaultWorkspace(ws); > } > > Wouldn't this solve your problem and prevent similar potential issues in > other places? > > Cheers > Andrea > > > -- > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via di Montramito 3/A > 55054 Massarosa (LU) > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* > > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il > loro utilizzo è consentito esclusivamente al destinatario del messaggio, > per le finalità indicate nel messaggio stesso. Qualora riceviate questo > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di > darcene notizia via e-mail e di procedere alla distruzione del messaggio > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od > utilizzarlo per finalità diverse, costituisce comportamento contrario ai > principi dettati dal D.Lgs. 196/2003. > > > > The information in this message and/or attachments, is intended solely for > the attention and use of the named addressee(s) and may be confidential or > proprietary in nature or covered by the provisions of privacy act > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection > Code).Any use not in accord with its purpose, any disclosure, reproduction, > copying, distribution, or either dissemination, either whole or partial, is > strictly forbidden except previous formal approval of the named > addressee(s). If you are not the intended recipient, please contact > immediately the sender by telephone, fax or e-mail and delete the > information in this message that has been received in error. The sender > does not give any warranty or accept liability as the content, accuracy or > completeness of sent messages and accepts no responsibility for changes > made after they were sent or for other risks which arise as a result of > e-mail transmission, viruses, etc. > > ------------------------------------------------------- >
------------------------------------------------------------------------------
_______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
