On 2017-06-30 12:22 PM, Torben Barsballe wrote: > While working on the fix > <https://github.com/geoserver/geoserver/pull/2445> to GEOS-8134 > <https://osgeo-org.atlassian.net/browse/GEOS-8134>, I encountered the > following: > > The GeoServerDataDirectory class has a number of "get__()" methods > with a workspace version and a no workspace (global) version.For > example: getStyles() > <https://github.com/geoserver/geoserver/blob/master/src/main/src/main/java/org/geoserver/config/GeoServerDataDirectory.java#L1087-L1107>. > > > Typically, in the catalog if a null workspace is provided, the global > 'workspace' is assumed. > However, if you provide a null workspace to one of these methods, you > get back the root of the data dir > <https://github.com/geoserver/geoserver/blob/master/src/main/src/main/java/org/geoserver/config/GeoServerDataDirectory.java#L822>, > instead of whatever you were asking for. This behaviour seems contrary > to how most of the rest of GeoServer works, and rather error prone. > > I would like to suggest changing these methods to handle the case of a > null workspace as if it were the global "workspace".
Yes, that looks like it may have been a problem introduced when we switched to ResourceStore. -- Kevin Michael Smith <[email protected]>
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
