Hi,
I cannot see a situation where the current behavior has any benefit and
it seems to me that returning the root directory is dangerous and an
inconsistent behavior.
Imagine the case where we want to remove something but for some
reason the workspace is NULL ... we may end up removing the whole
data directory.
As commented on this PR [1] I would expect one of this two behaviors:
* ignore the workspace if it is NULL
* throw an exception if the workspace is NULL
Regards,
[1] https://github.com/geoserver/geoserver/pull/2445
On 07/05/2017 08:27 PM, Kevin Smith wrote:
On 2017-06-30 12:22 PM, Torben Barsballe wrote:
While working on the fix <https://github.com/geoserver/geoserver/pull/2445> to
GEOS-8134 <https://osgeo-org.atlassian.net/browse/GEOS-8134>, I encountered the
following:
The GeoServerDataDirectory class has a number of "get__()" methods with a workspace
version and a no workspace (global) version.For example: getStyles()
<https://github.com/geoserver/geoserver/blob/master/src/main/src/main/java/org/geoserver/config/GeoServerDataDirectory.java#L1087-L1107>.
Typically, in the catalog if a null workspace is provided, the global
'workspace' is assumed.
However, if you provide a null workspace to one of these methods, you get back the
root of the data dir
<https://github.com/geoserver/geoserver/blob/master/src/main/src/main/java/org/geoserver/config/GeoServerDataDirectory.java#L822>,
instead of whatever you were asking for. This behaviour seems contrary to how most
of the rest of GeoServer works, and rather error prone.
I would like to suggest changing these methods to handle the case of a null workspace as
if it were the global "workspace".
Yes, that looks like it may have been a problem introduced when we switched to
ResourceStore.
--
Kevin Michael Smith
<[email protected]>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i
file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo
è consentito esclusivamente al destinatario del messaggio, per le finalità
indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne
il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di
procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro
sistema. Conservare il messaggio stesso, divulgarlo anche in parte,
distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse,
costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
